Closed
Bug 802903
Opened 12 years ago
Closed 12 years ago
The function blapi_pqg_param_gen is missing the return type
Categories
(NSS :: Tools, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
3.14.1
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
|
604 bytes,
patch
|
rrelyea
:
review+
|
Details | Diff | Splinter Review |
The function blapi_pqg_param_gen in cmd/bltest/blapitest.c was added in bug 475578. It is missing the return type. I believe a C function without a return type is considered as returning int. Since SECStatus is an enum type, it should be automatically converted to or from an int. So it doesn't seem necessary to include this fix in a new release candidate for NSS 3.14.
Attachment #672618 -
Flags: review?(rrelyea)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 672618 [details] [diff] [review] Proposed patch r+ rrelyea
Attachment #672618 -
Flags: review?(rrelyea) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Patch checked in on the NSS trunk (NSS 3.14.1). Checking in blapitest.c; /cvsroot/mozilla/security/nss/cmd/bltest/blapitest.c,v <-- blapitest.c new revision: 1.71; previous revision: 1.70 done
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•