802906 - If I sync everything (add-ons included) with a lot of data, new tabs do not show up on the tab strip

Status: RESOLVED WORKSFORME

(Firefox :: Sync, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

If I sync every possible item, Sync takes some time to run, and in the process the "+" button seems to add a new tab, and it's working, but it does not appear on the tab strip.

e.g. the tab strip still shows 2 tabs even though we've added more tabs.

(It does not seem to appear until Sync has finished, which can take a long time. In my tests, sometimes they appeared eventually, sometimes they didn't)

Thanks Matt for helping me look into this.

Comment 1

[Richard Newman [:rnewman]]

Is this only on WinXP? Is it only on a first sync?

I can't reproduce on Mac with an incremental sync.

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Seems to only be on first sync, and yes I seem to only notice this on WinXP.

(I've been setting up new Firefox instances across platforms like Mac 10.7/10.8, Linux and Win7 and I don't notice this problem, not on first sync nor incremental sync)

Comment 3

[Richard Newman [:rnewman]]

To be honest, I feel that it's unlikely that this bug will be directly addressed before XP is no longer in either Microsoft's extended support period (it ended mainstream support more than two years ago), or Firefox no longer supports XP… it's just not important enough unless functionality is significantly impaired.

(If you couldn't load pages during syncing, for example.)

But regardless — the culprit here is perhaps some difference in how the event loop is processed on XP. Sync spins the event loop in order to provide UI responsiveness, but that's actually a bad thing. We'll likely fix this eventually when we finish our async rewrite.

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

hmmm I just rechecked, on first sync I think I see this on Windows 7 as well, but not Linux and Mac.

Comment 5

[Tracy Walker [:tracy]]

I can not reproduce this on Win 7. I can reproduce it on XP. I think this and bug 802904 are dupes of each other.  During first sync, if you close the Options dialog then start clicking to open new tabs, the new tabs aren't opened 'til sync is complete. Once it is complete, the progress tab opens followed by the new tabs.  

Seems like the animation of opening a new tab is being stalled. I don't see anything in new tab animation since a telemetry probe was added in bug 708788.

Comment 6

[Tracy Walker [:tracy]]

check that, a snappy bug on tab animation bug 752839 which was fixed by bug 716108 is much more recent. I'll regression test around that time.

Comment 7

[Tracy Walker [:tracy]]

Those fixes are not to blame.  I see this back to at least Fx 10.0.7 esr. :-(

Comment 8

[Richard Newman [:rnewman]]

(In reply to Tracy Walker [:tracy] from comment #7)
> Those fixes are not to blame.  I see this back to at least Fx 10.0.7 esr. :-(

Well, that makes me feel better about pushing this train through, and it presumably means that Bug 795800 is going to be easier to track down :)

Thanks for the investigation, Tracy!

I'm going to kill the regression keyword, because it's old enough that I regard it as ancient history…

Comment 9

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I don't think I have seen this recently with Firefox Accounts.