802934 - tab stops moving during dragging if mouse pointer leaves the tab strip

Status: RESOLVED DUPLICATE of bug 450915

(Firefox :: Tabbed Browser, defect)

Description

[timbugzilla]

While dragging a tab to a new position in the tab strip, if the mouse pointer moves to above or below the tab strap then dragging stops. There is no vertical margin for error.

This makes interaction seem jerky and frustrating (unless you move your mouse in a near horizontal line, and not in an arc). 

The tab should continue to drag in the horizontal component direction of mouse movement, even if the mouse leaves the tab strip (within some reasonable vertical margin).

This may be more of a problem with a mouse rather than a touch pad.

Comment 1

[Ioana (away)]

timbugzilla, can you reproduce this issue with a clean profile or in safe mode?
http://support.mozilla.com/kb/Basic+Troubleshooting#w_8-make-a-new-profile
http://support.mozilla.com/kb/Safe+Mode

Comment 2

[timbugzilla]

Thanks for checking this out. 

Yes, I can reproduce this in both safe mode and with a fresh profile.

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I can confirm this bug on latest Nightly
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:19.0) Gecko/19.0 Firefox/19.0
buildID: 20121103180514

Comment 6

[Mehmet]

Please add a tolerance area. This really lose the sense of smoothness...

Comment 7

[Ioana (away)]

Confirmed on the 12/11 Nightly.

Comment 8

[nivtwig]

I can confirm this bug today, 5 years later ...

Comment 9

[timbugzilla]

(In reply to nivtwig from comment #8)
> I can confirm this bug today, 5 years later ...

Hey, better late than never.

Comment 11

[:Gijs (he/him)]

This was fixed in bug 450915.

Comment 12

[Mehmet]

(In reply to :Gijs (slow, PTO recovery mode) from comment #11)
> This was fixed in bug 450915.

Hello :Gijs

I think this issue is still reproducible in latest Nightly 58.0a1 (2017-11-10) (64-Bit).

If you drag a tab and the mouse cursor moves while dragging process a little bit outside the tabstrip area, the dragging animation stops.

Can you please recheck if this is really a duplicate of issue 450915?

Please find a screencast attached.

Thanks.

Comment 13

[Mehmet]

Attachment: screencast_tab_dragging.mov

Comment 14

[:Gijs (he/him)]

(In reply to Mehmet from comment #12)
> (In reply to :Gijs (slow, PTO recovery mode) from comment #11)
> > This was fixed in bug 450915.
> 
> Hello :Gijs
> 
> I think this issue is still reproducible in latest Nightly 58.0a1
> (2017-11-10) (64-Bit).
> 
> If you drag a tab and the mouse cursor moves while dragging process a little
> bit outside the tabstrip area, the dragging animation stops.
> 
> Can you please recheck if this is really a duplicate of issue 450915?
> 
> Please find a screencast attached.

You can see in the screencast that dragging stops when you're already halfway down the navbar. It used to stop immediately as soon as you crossed from the dark line of tabs to the lighter-coloured navbar (colours in that screencast to clarify what I mean).

If you think the margin provided here is not big enough, file a separate bug to increase the margin of error we now support. This is a trade-off because it has to stay (easily) possible to detach tabs or drag/drop items into the bookmarks toolbar etc.

As filed, I think the bug is fixed. There's just disagreement here about what "reasonable" means here:

(In reply to timbugzilla from comment #0)
> The tab should continue to drag in the horizontal component direction of
> mouse movement, even if the mouse leaves the tab strip (within some
> reasonable vertical margin).

Comment 15

[Mehmet]

Thank you for your feedback. I‘ll file a sparate report then. Since other browsers like Chrome, Safari and Vivaldi has a bigger vertical margin, Firefox should also follow this behaviour. A bigger vertical margin makes the animation more fluid without any break while moving a tab.