Unify "fast call" attribute handling

NEW
Unassigned

Status

()

Core
General
6 years ago
6 years ago

People

(Reporter: espindola, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

xpcom/base/nscore.h has

#if defined(__i386__) && defined(__GNUC__) && \
    (__GNUC__ >= 3) && !defined(XP_OS2)
#define NS_FASTCALL __attribute__ ((regparm (3), stdcall))

js/src/jstypes.h has

#elif defined(__GNUC__) && defined(__i386__) &&                         \
  ((__GNUC__ >= 4) || (__GNUC__ == 3 && __GNUC_MINOR__ >= 4))
#define JS_FASTCALL __attribute__((fastcall))

We should decide on regparm or fastcall and add a MOZ_FASTCALL to mfbt.
You need to log in before you can comment on or make changes to this bug.