Closed Bug 802977 Opened 7 years ago Closed 7 years ago

B2G RIL : Update comments in SimToolKit.idl

Categories

(Core :: DOM: Device Interfaces, defect)

All
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: allstars.chh, Assigned: allstars.chh)

Details

Attachments

(1 file, 1 obsolete file)

I notice there are some out-dated comments in dom/icc/interface/SimToolKit.idl, 
for example, STK_CMD_REFRESH is repeated twice in the comments of MozStkCommand.options,
also in MozStkCallEvent, in the comments of isIssuedByRemote, STK_EVENT_TYPE_CALL_DISCONNECTED is repeated twice, the first occurrence should be STK_EVENT_TYPE_CALL_CONNECTED.
Assignee: nobody → allstars.chh
Attachment #672699 - Flags: review?(philipp)
Comment on attachment 672699 [details] [diff] [review]
Patch to update comments

Review of attachment 672699 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/icc/interfaces/SimToolKit.idl
@@ +478,5 @@
>  
>    /**
>     * This field is available in 'STK_EVENT_TYPE_CALL_CONNECTED' and
>     * 'STK_EVENT_TYPE_CALL_DISCONNECTED' events.
> +   * For STK_EVENT_TYPE_CALL_CONNECTED event, setting this to true means the

s/For/For the/
Attachment #672699 - Flags: review?(philipp) → review+
Addressed to philikon's comments.
s/For/For the/
Attachment #672699 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/32653fd17e58
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.