803015 - [click to play] plugin placeholder text can be styled by page style

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Paul Rouget [:paul]]

(Found on reddit: http://www.reddit.com/r/firefox/comments/11n4lp/is_this_a_firefox_bug_or_intended/)

When plugins.click_to_play is true, there is a message that is displayed that states "Click here to activate..".

This message usually disregards all CSS declarations set on the element (e.g. color, font) except, for some weird reason, the text-transform property.

Shouldn't the text-transform property value be overridden to none to keep the message uniform? It does not look appropriate when set to uppercase or lowercase - in fact, I actually thought it was a scam image when I first encountered it.

Website: http://runpee.com
Image: http://i.imgur.com/P5jdk.png

Tested on and reproducible in (Windows 7) Firefox 16.0.1, 17.0 (Beta) and 18.0a2 (Aurora).

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Using the test page in comment #0, I tried also setting text-decoration:underline !important, color: red !important, and changing the font but didn't see those styles inheriting.

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 673728 [details] [diff] [review]
Patch

> .mainBox {
>   width: inherit;
>   height: inherit;
>   overflow: hidden;
>   direction: ltr;
>   unicode-bidi: embed;
>+  /* used to block inherited properties */
>+  text-transform: none !important;

Why would you need !important here?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v1.1

Yeah, the important isn't needed. I forgot to test without it.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca0bbaaf0282

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ca0bbaaf0282

Possible to test this?

Comment 6

[Suraj Patel]

Attachment: Testcase of more inherited CSS

Other CSS properties that are also inherited by the plugin placeholder. Need to be explicitly set to the default, as in the case of the text-transform property. I'd add to the patch myself, but I have no clue how this works.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to suraj_patel_95 from comment #6)
> Created attachment 677441 [details]
> Testcase of more inherited CSS
> 
> Other CSS properties that are also inherited by the plugin placeholder. Need
> to be explicitly set to the default, as in the case of the text-transform
> property. I'd add to the patch myself, but I have no clue how this works.

Can you please file a new bug and attach the test case to the new bug? Thanks!

Comment 8

[Suraj Patel]

(In reply to Jared Wein [:jaws] from comment #7)
> (In reply to suraj_patel_95 from comment #6)
> > Created attachment 677441 [details]
> > Testcase of more inherited CSS
> > 
> > Other CSS properties that are also inherited by the plugin placeholder. Need
> > to be explicitly set to the default, as in the case of the text-transform
> > property. I'd add to the patch myself, but I have no clue how this works.
> 
> Can you please file a new bug and attach the test case to the new bug?
> Thanks!

Done: https://bugzilla.mozilla.org/show_bug.cgi?id=807880