Closed Bug 803022 Opened 12 years ago Closed 11 years ago

bugs when going "back" with swipe gesture

Categories

(Core :: Widget: Cocoa, defect)

18 Branch
x86_64
macOS
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox17 + wontfix
firefox18 - ---
firefox19 - ---

People

(Reporter: fb+mozdev, Unassigned)

References

Details

(Whiteboard: [start from Comment 32])

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20121010150351

Steps to reproduce:

Visit https://www.contao-community.de/newreply.php?p=227322&noquote=1 and type something – this is a vBulletin 4 post editor. Then navigate back (e. g. to see the original thread without submitting my text) with 2-finger-swipe. 


Actual results:

Prompt is shown for a moment, then Firefox crashes. 


Expected results:

Prompt is not shown, Firefox navigates back. Without crashing.
This is what I got to see from the crash report: 

AdapterDeviceID: 0x 166
AdapterVendorID: 0x8086
Add-ons: kitsuneymg%40gmail.com:1.0.6,macos-keychain%40fitzell.ca:1.1.3,youtubeunblocker%40unblocker.yt:0.2.0,%7B45d8ff86-d909-11db-9705-005056c00008%7D:1.1.0,%7Baede9b05-c23c-479b-a90e-9146ed62d377%7D:1.2.1,firefontfamily%40firebugextensions.org:0.1.2,artur.dubovoy%40gmail.com:3.7.1,%7B73a6fe31-595d-460b-a920-fcc0f8843232%7D:2.5.7,%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D:17.0,%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D:2.1.2,firebug%40software.joehewitt.com:1.10.4
BuildID: 20121010150351
Comments: crashing when unload: when in vBulletin 4 (on contao-community.de) editor with some text entered, navigating back via gesture will show prompt() asking the user if he wants to discard his text and navigate away from the editor – message will appear and Fx immediately crashes

will post a bug. 
CrashTime: 1350512527
EMCheckCompatibility: true
Email: ***
FramePoisonBase: 7ffffffff0dea000
FramePoisonSize: 4096
InstallTime: 1350329730
Notes: AdapterVendorID: 0x8086, AdapterDeviceID: 0x 166GL Context? GL Context+ GL Layers? GL Layers+ WebGL? WebGL+ 
ProductID: {ec8030f7-c20a-464f-9b0e-13a3a9e97384}
ProductName: Firefox
ReleaseChannel: beta
StartupTime: 1350372636
Theme: classic/1.0
Throttleable: 1
URL: https://www.contao-community.de/newreply.php?p=227322&noquote=1
Vendor: Mozilla
Version: 17.0
Severity: normal → major
Depends on: 391834
Hardware: x86 → x86_64
Link to the crash report?
Sorry, don't know where to find it. That's why I appended the data I could see.
Load about:crashes 
It should have Report ID.
Ah thanks. I put the URL into crash signature.
Crash Signature: https://crash-stats.mozilla.com/report/index/bp-ea057ce6-5707-45fc-ab22-43d812121017
Looks quite a bit like Bug 776497.
Can you reproduce the crash in safe mode?
I will try it later today or tomorrow. 

Note: I'm able to reproduce the crash in *normal* mode every time.
Your report: https://crash-stats.mozilla.com/report/index/bp-ea057ce6-5707-45fc-ab22-43d812121017
Crash Signature: https://crash-stats.mozilla.com/report/index/bp-ea057ce6-5707-45fc-ab22-43d812121017 → [@ nsGlobalWindow::SetNewDocument ]
Keywords: crash
Blocks: 391834
Severity: major → critical
Status: UNCONFIRMED → NEW
No longer depends on: 391834
Ever confirmed: true
Keywords: regression
Could you please give exact steps to reproduce for someone who doesn't speak German
and who doesn't have account for the web site, thanks.
Yeah, I was already looking for a demo forum, but now I hit another (probably related) issue: 

1) Visit http://www.forum-software.org/demo/vbulletin4
2) Login (use account details I provided via e-mail)
3) Go to main forum, thread "test".
4) Hit reply and then in the bottom form "Go Advanced".
5) Type something into the text field (it may need to be longer than 10 characters).
6) Navigate back (I used 2-finger-swipe on mac).

On this forum (vB 4.1.12) I just saw a prompt with buttons (with text) but I could not do anything (like a freeze, but the UI did not seem to have freezed as one button (the default) was flashing blue-ish – normal Mac OS X behaviour). The second time I saw a prompt again, but the buttons had no text and neither button flashed or was even (pre-)selected. I was able to escape this situation by killing Fx and restarting (the warning page was shown where I could deselect the problematic tab before restoring other tabs). 

I will send you the credentials in a minute.
OK, another test, another result (with newly created user). 

1) Goto https://www.contao-community.de/.
2) Login (see e-mail for credentials).
3) Goto https://www.contao-community.de/showthread.php?34634-Contao-und-SEO.
4) Hit "Antworten".
5) Type something into the main text field. 
6) Navigate back (I used 2-finger-swipe on Mac).
7) Whatch it collapse? 

The first result was: The intended result (no message, no crash, just navigating). 
The second result (I used the browser back button): Message, no crash, just like Fx pre-17. Then I navigated away from the editor and hit "Antworten" again. 
The third result (I used the browser back button): Message, no crash, just like Fx pre-17.
The fourth result (2-finger-swipe): Endless question answer game, no matter which button I pressed. 
However, no crashes. 


Boy, this does not work very well ;-).
Please confirm if this is indeed a dupe of bug 776497 since we were looking for STR there to get some traction and this would be very helpful.
I tried with FF19 on Win 7, I'm not able to reproduce the issue. Maybe it's OSX-specific...
> Actual results:
> 
> Prompt is shown for a moment, then Firefox crashes. 
> 
> 
> Expected results:
> 
> Prompt is not shown, Firefox navigates back. Without crashing.
I see the beforeunload prompt. No crash.
I was using Linux
New crash report for page mentioned in Comment 1 (or the description): https://crash-stats.mozilla.com/report/index/bp-5c70b6ed-8da2-43eb-b081-c93bf2121026

So I was able to see the prompt but Fx crashed before I could react. 

This was with Beta 1. Now my Fx is Beta 3. Will try it one more time with this version.
I tried again with b3 and got into the loop but no crash.
(In reply to Florian Bender from comment #19)
> I tried again with b3 and got into the loop but no crash.

Does Firefox 16 act differently on these STR?
Keywords: qawanted
I did not experience this behaviour before, but I cannot specifically exclude Fx 16 from this behaviour. 

How can I install two separate versions of Fx on Mac OS X? If Fx 16 interferes in any way with my main browser (Fx Beta --> Fx 17), I'm afraid it is not possible for me to test if this behaviour appears in Fx 16. 

(What does STR mean? I only have a raw guess …)
(In reply to Florian Bender from comment #21)
> How can I install two separate versions of Fx on Mac OS X? If Fx 16
> interferes in any way with my main browser (Fx Beta --> Fx 17), I'm afraid
> it is not possible for me to test if this behaviour appears in Fx 16. 

See http://xulforge.com/blog/2011/07/multiple-firefox-instances-mac/

> (What does STR mean? I only have a raw guess …)

It means Steps To Reproduce.
Thank you. 

Well. Firefox 16.0.2 indeed exhibits the same behaviour when I reproduce what I've written in the bug description: No matter what button I click, I cannot escape the prompt() resp. immediately after that, the same prompt appears again. 

When I tried the STR in Comment 12, Firefox 16.0.2 crashed (but using *my own* account): https://crash-stats.mozilla.com/report/index/bp-197440a2-e017-42fd-ae06-f9b232121104 – however using the mozdev account, the loop problem appears (in both cases). 

Strange. 

I'm always using the swipe gesture to go back. When I click another link on the editor site, I also get prompted but the prompt works as expected. 

**When I use the __back button__, the prompt works as expected!**

Now I think this problem is related to event handling and gestures, probably Mac OS X only! I can reproduce this issue with the mozdev account every time. 

Concerning the crash: I can only reproduce it with my account. I may provide access to my account to one or a few selected people in the following days to let them reproduce the crash.
Lukas, I believe comment 23 addresses your request for qawanted. Please re-add if there is something else you need.
Keywords: qawanted
We're past the point of accepting speculative fixes for 17 as we approach our final beta, so wontfixing this for 17.  Adding qawanted again though - Anthony or someone else, can you take Florian up on his offer in comment 23 to test with his account and see if there's something up with that account vs. the one that doesn't reproduce?
Juan, can you please work with Florian to address Lukas' request for qawanted?
QA Contact: jbecerra
Not sure if it is the same as the crash in Bug 776497 Comment 42, but my latest comment has a reproducible site that doesn't require any login credentials.
QA Contact: jbecerra → marcia
I'm sorry, as of today I no longer can reproduce the crash in Fx 16. I don't know what I do differently. I reset the profile, set-up a new profile, altered the STR, etc. Nothing. I could reproduce it before. I don't know what happened between now and before (actually, I think: nothing changed).
As for this bug, I now get a prompt where I can click any button and the prompt disappears and appears again (a loop), and sometimes I can click any button in the button but nothing happens (I can see the button flashing blue, but the prompt does not disappear) (unresponsive, but no stalled UI!). I checked this in Firefox 16.0.2 on a MBA 2012. 

As this only happens with the swipe gesture and not the back button, I now think this problem comes from some misfired events: The swiping gesture event fires several times for one swipe thus leading to the "loop". I don't know if the "unresponsive" problem has the same root cause or is a separate issue. 


I clarified the bug parameters a bit (I hope this is ok). If I hit the crash again (reliably), I will report it in Bug 776496.
Component: DOM → Event Handling
Summary: Crash when prompt() on leaving a page (because of: Don't allow alert/confirm/prompt in onbeforeunload, onunload and onpagehide?) → prompt() misbehaviour when going "back" with swipe gesture (because of: Don't allow alert/confirm/prompt in onbeforeunload, onunload and onpagehide?)
Whiteboard: [start from Comment 23 and 29]
Version: 17 Branch → 16 Branch
This hasn't been called out as having major user impact post-FF17 release, so no need to track for upcoming releases.
Bug 812758 is also about weird behaviour when using the swipe gesture. 


Downgrading this Bug as it seems like this is not really crash issue (probably fixed in Bug 776497 – I just saw I referenced the wrong Bug Id in my last comment) but a gesture/event handling issue (Mac-only?). 

(I hope this bug is in the right category, otherwise please move it to something more fitting or Triage.)
Severity: critical → normal
Crash Signature: [@ nsGlobalWindow::SetNewDocument ]
Depends on: 776497
Keywords: reproducible
See Also: → 812758
So it really looks like this is a swipe gesture bug. It seems like the swipe event is fired multiple times in a short period of time and clutters up the task cue (just a guess). 

This (so far) results in: 
1. The "form has been filled out but not sent"-prompt sometimes does not respond OR is showed again and again (endless? loop) after clicking one of the prompt buttons OR may even be missing information (buttons without text etc.) – see details above.
2. Visual artifact on back button: The sliding animation results in stripes (see attachement). 

Moving this to Fx component as this does not seem to be a Core issue (for now – though it may be if system-events are not handled correctly in Core).
Component: Event Handling → Untriaged
Product: Core → Firefox
Summary: prompt() misbehaviour when going "back" with swipe gesture (because of: Don't allow alert/confirm/prompt in onbeforeunload, onunload and onpagehide?) → bugs when going "back" with swipe gesture
Whiteboard: [start from Comment 23 and 29] → [start from Comment 32]
Version: 16 Branch → 18 Branch
The "lines" are not always visible when navigating with the swipe gesture, and the pattern changes (it may depend on swiping speed and duration). However most of the time, there are visible stripes overlaying the forward button.
Untriaged does not seem like the right component, since this has already been triaged and confirmed. I'm suggesting this is appropriate for Shell Integration but I could be wrong. Feel free to move where appropriate.
Component: Untriaged → Shell Integration
I don't know what "Sheel Integration" means or stands for. I'd like this bug to be re-triaged as it turned out to be a totally different issue as originally assumed. Plus, this is probably something for JAWS Mac OS compat effort.
Fair enough.
Component: Shell Integration → Untriaged
Moving to Core -> Widget:Cocoa as that is where the swipe back/forward bug work is and is likely to be the correct place for this.
Component: Untriaged → Widget: Cocoa
Product: Firefox → Core
Depends on: 678392
Depends on: history-swipe
I can no longer reproduce the issue on latest Nightly 26.0a1 (2013-08-13), closing then.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
Depends on: 1382560
No longer depends on: 1382560
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: