Closed Bug 803066 Opened 8 years ago Closed 8 years ago

graphite2 fails to cross compile for Windows from case sensitive OS

Categories

(Core :: Graphics: Text, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file)

Attached patch fixSplinter Review
The fix is as trivial as using lower-case includes for platform headers. Also submitted upstream:

http://projects.palaso.org/issues/1030
Attachment #672767 - Flags: review?
Attachment #672767 - Flags: review? → review?(jfkthame)
Comment on attachment 672767 [details] [diff] [review]
fix

Looks fine to me.

I notice there are also a bunch of <Windows.h> in Skia - presumably that'll cause similar issues.
Attachment #672767 - Flags: review?(jfkthame) → review+
(In reply to Jonathan Kew (:jfkthame) from comment #1)
> Looks fine to me.

Thanks for the review.

> I notice there are also a bunch of <Windows.h> in Skia - presumably that'll
> cause similar issues.

Yes, it's covered by bug 803063.
https://hg.mozilla.org/mozilla-central/rev/302da397199e
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.