Closed Bug 803160 Opened 12 years ago Closed 7 years ago

17b1 breaks behavior in onStopRequest at the network layer

Categories

(Firefox :: Extension Compatibility, defect)

Product:
Firefox
Component:
Extension Compatibility
Version:
17 Branch
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: dstaudigel, Unassigned)

Details

Network loading is not functional when using the Cocoon (getcocoon.com) extension with 17b1.   As the author of all of the relevant code in the extension, I cannot identify the reason, and I cannot find any leads in https://developer.mozilla.org/en-US/docs/Firefox_17_for_developers.

Here is what I have been able to figure out:  Resources are loaded through a proxy.  To make this work correctly, http channels are wrapped with a JS intermediary that makes sure the content of the website is delivered with the correct metadata (URLs, headers, references to channels, etc.).  There is some problem in the intermediary layer during onStopRequest that I haven't seen before.  Data is being retrieved from the network successfully (onStartRequest/onDataAvailable are being called), but this data never becomes visible to the user - possibly because of some changes to onStopRequest or something similar.  Have there been any changes made to this mechanism that might be triggering this problem?
Does the extension work in previous versions of Firefox like 16 or 15?
Yes, it is working in 15 and 16.
How can we test that? Installing the Cocoon extension is enough?

Provide better accurate STR, please. Or a small testcase.
STR: Install Cocoon (https://getcocoon.com/support/download), and log in with a "free" account (https://getcocoon.com/signup_free).  Browsing to most websites that I tested resulted in no URLs being displayed in the URL bar and interaction that didn't work right.  Errors started occurring when the intermediate layer tried to remove channels for cleanup from load groups during onStopRequest.
There are networking changes in Firefox17 to remove synchronous DNS. One bug caused by this changes are already fixed with bug 797684

Are you using a proxy during your tests ?
Component: Untriaged → Extension Compatibility
No proxy during this test - should I do a test with a proxy?
(In reply to Matthias Versen (Matti) from comment #5)
> There are networking changes in Firefox17 to remove synchronous DNS. One bug
> caused by this changes are already fixed with bug 797684
> 
> Are you using a proxy during your tests ?

That fix (and 769764 which is the big change) are not on firefox 17. (18, and 19 yes).
Update: just updated my firefox beta - the problem is still there.
(In reply to dstaudigel from comment #8)
> Update: just updated my firefox beta - the problem is still there.
Please try again on FF 18 and 19 due to comment 7.
Tried with FF18 (Aurora?) - network connectivity has the same problem.  As for 19, I couldn't find a pre-built version of, so I was unable to test it.  I have a hunch that this is actually a JS/C++ interface change - has anything changed in that department?
This is about a legacy extension which is no longer valid in Firefox Quantum, closing.
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.