Closed Bug 803192 Opened 12 years ago Closed 12 years ago

Can't update Firefox from 15.0.1 to 16.0.1

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Version:
16 Branch
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 789958

People

(Reporter: Usul, Unassigned)

Details

Attachments

(1 file)

lslr.txt permission of Firefox
12.82 KB, text/plain
Details 
On my gf's machine when I check for update , I get a download but it fails to apply.

last-update.log contains :
Performing a background update
SOURCE DIRECTORY /Applications/Firefox.app/Contents/MacOS/updates/0
DESTINATION DIRECTORY /Applications/Firefox.app/Updated.app
ensure_copy: failed to open the file for reading: /Applications/Firefox.app/Contents/MacOS/crashreporter.app/Contents/_CodeSignature/CodeResources, err: 1
failed: 6
calling QuitProgressUI

backup-update.log contains the same thing.

Anything I should add to make sure we can nail down this issue ?
Can you post all of updates*

And also set app.update.log to True, rerequest an update, and paste the output containing "https://aus3.mozilla.org" from the error console?
This might be bug 789958, it's weird that CodeResources is the file it's having trouble with though. What user are you logged in with, and what user owns Firefox.app?
cc'ing ehsan in case this is related to bug 789958.
(In reply to Ben Hearsum [:bhearsum] from comment #1)
> Can you post all of updates*
> 
> And also set app.update.log to True, rerequest an update, and paste the
> output containing "https://aus3.mozilla.org" from the error console?

AUS:SVC Checker:checkForUpdates - sending request to: https://aus3.mozilla.org/update/3/Firefox/15.0.1/20120905151427/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/release/Darwin%2010.8.0/default/default/update.xml?force=1

(In reply to Ben Hearsum [:bhearsum] from comment #2)
> This might be bug 789958, it's weird that CodeResources is the file it's
> having trouble with though. What user are you logged in with, and what user
> owns Firefox.app?


It doesn't work from my wife's account, nor from mine. I own the app.

-rw-r--r--@ 1 ludo  admin  347 Oct 14 14:28 backup-update.log
-rw-r--r--@ 1 ludo  admin  347 Oct 14 14:28 last-update.log
drwxr-xr-x@ 2 ludo  admin   68 Oct 14 14:28 0

0 is an empty directory

Ludovic-Hirlimanns-MacBook-Pro-2:updates zola$ cat *
cat: 0: Is a directory
Performing a background update
SOURCE DIRECTORY /Applications/Firefox.app/Contents/MacOS/updates/0
DESTINATION DIRECTORY /Applications/Firefox.app/Updated.app
ensure_copy: failed to open the file for reading: /Applications/Firefox.app/Contents/MacOS/crashreporter.app/Contents/_CodeSignature/CodeResources, err: 1
failed: 6
calling QuitProgressUI
Performing a background update
SOURCE DIRECTORY /Applications/Firefox.app/Contents/MacOS/updates/0
DESTINATION DIRECTORY /Applications/Firefox.app/Updated.app
ensure_copy: failed to open the file for reading: /Applications/Firefox.app/Contents/MacOS/crashreporter.app/Contents/_CodeSignature/CodeResources, err: 1
failed: 6
calling QuitProgressUI
Can you package up the entire app in a tarball? And also attach the output of this, so we can get a full sense of the permissions:
ls -lR /Applications/Firefox.app
(In reply to Ben Hearsum [:bhearsum] from comment #5)
> Can you package up the entire app in a tarball? And also attach the output
> of this, so we can get a full sense of the permissions:
> ls -lR /Applications/Firefox.app

Tarball coming up , here is the output of ls -lR /Applications/Firefox.app
tarball is at perso.hirlimann.net/~ludo/ff.tar.bz2
Comment on attachment 673859 [details]
lslr.txt permission of Firefox

Looks like Firefox.app//Contents/MacOS/updater.app/Contents/_CodeSignature/CodeResources is owned by root for some reason. I don't really understand how that can happen, unless you ran Firefox and tried to update as root....
(In reply to Ben Hearsum [:bhearsum] from comment #8)
> Comment on attachment 673859 [details]
> lslr.txt permission of Firefox
> 
> Looks like
> Firefox.app//Contents/MacOS/updater.app/Contents/_CodeSignature/
> CodeResources is owned by root for some reason. I don't really understand
> how that can happen, unless you ran Firefox and tried to update as root....

I have not and root is not an enabled on this cleanly reinstalled machine.
(In reply to Ben Hearsum [:bhearsum] from comment #8)
> Comment on attachment 673859 [details]
> lslr.txt permission of Firefox
> 
> Looks like
> Firefox.app//Contents/MacOS/updater.app/Contents/_CodeSignature/
> CodeResources is owned by root for some reason. I don't really understand
> how that can happen, unless you ran Firefox and tried to update as root....

Hm, actually. That file is the signature of updater.app???? That doesn't make a lot of sense to me, AFAIK we don't sign it...

Still investigating.
(In reply to Ben Hearsum [:bhearsum] from comment #10)
> (In reply to Ben Hearsum [:bhearsum] from comment #8)
> > Comment on attachment 673859 [details]
> > lslr.txt permission of Firefox
> > 
> > Looks like
> > Firefox.app//Contents/MacOS/updater.app/Contents/_CodeSignature/
> > CodeResources is owned by root for some reason. I don't really understand
> > how that can happen, unless you ran Firefox and tried to update as root....
> 
> Hm, actually. That file is the signature of updater.app???? That doesn't
> make a lot of sense to me, AFAIK we don't sign it...
> 
> Still investigating.

Indeed, we don't have that file at all in this package: https://ftp.mozilla.org/pub/mozilla.org/firefox/releases/15.0.1/mac/en-US/Firefox%2015.0.1.dmg.

For curiosity's sake, can you try downloading a fresh 15.0.1 onto your Desktop (or somewhere else), and seeing if you can repro? And if the above file exists in it?
How did you get 15.0.1? Did you upgrade from a previous version? Can you attach your updates.xml?
(In reply to Ben Hearsum [:bhearsum] from comment #12)
> How did you get 15.0.1? Did you upgrade from a previous version? Can you
> attach your updates.xml?

I didn't it was a fresh install. trying from my work machine. I probably still have the downloaded image.


And I don't see it in a fresh download.

So what I did was :

Cleanup the machine and install a fresh OS.
Downloaded Ff and Thunderbird install them - I'm pretty sure I went trhu get firefox for that.

Anything else I should do before doing fresh installs ?
Where did you download Firefox from, exactly?
Oh, and the entire appdir zipped up would still be useful. Please don't delete that directory until we have a chance to debug this.
So, according to comment 0, we fail to open this file for reading: /Applications/Firefox.app/Contents/MacOS/crashreporter.app/Contents/_CodeSignature/CodeResources.  This error is reported from here: <http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/updater/updater.cpp#643> which means that ensure_open is failing.  This is most likely because we try to chmod that file when opening it for reading (with "rb" passed to fopen) which is the same thing that we saw in bug 789958.  We fixed bug 789958 on 16, so 15 and 15.0.1 installations that have files owned by root inside them will still be affected.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
I'm still curious to know how the Firefox got in this state, but I'm not sure we'll be able to find out....
(In reply to comment #17)
> I'm still curious to know how the Firefox got in this state, but I'm not sure
> we'll be able to find out....

That I have no clue about!  Maybe we should file another bug and CC people who know how this stuff works on Mac?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: