803206 - [Bluetooth Settings] Icons overlap with text string for device name

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P2)

Description

[Peter La]

Attachment: Screenshot

Go to Settings->Bluetooth.
Turn on Bluetooth and watch as devices are detected.

Actual:
The devices that have longer names have name strings that overlap their device type icon. (See attached screenshot).

Expected:
The name string should be cut off and end with "..." or take up a second line to display (this would increase the list item height, which I'm not sure is desirable).

Comment 1

[Evelyn Hung]

Attachment: fix device name overlaps with icon, and some UI polish

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 676101 [details]
fix device name overlaps with icon, and some UI polish

All looks good and removed unnecessary paragraph tag.

Comment 3

[Evelyn Hung]

Comment on attachment 676101 [details]
fix device name overlaps with icon, and some UI polish

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 4

[Mike Connor [:mconnor]]

Not blocking, per triage.  We would accept a low-risk patch.

Comment 5

[Evelyn Hung]

Yes, I believe it's a low-risk patch. It also solved bug 804248 (bb+), so I decide to land it.

https://github.com/mozilla-b2g/gaia/pull/6052

Comment 6

[Mike Connor [:mconnor]]

Non-blockers do require explicit approval to land.  If the fix here is for the blocker as well it's probably something we'll let slide, but please be mindful of the rules in the future.

Comment 7

[Evelyn Hung]

Got it. Thanks, Mike.

Comment 10

[sarsenyev]

Reviewed and verified on "Unagi Device"
BuildID:20130102070202

Comment 11

[Evelyn Hung]

reopen the issue because it happens again on unagi 4/12 user build.

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

(In reply to Evelyn Hung [:evelyn] from comment #11)
> reopen the issue because it happens again on unagi 4/12 user build.

Please file a new bug for this - which still wouldn't block since it's polish - and provide a regression range.