Closed Bug 803253 Opened 8 years ago Closed 8 years ago

JS tests in Marionette are broken on TBPL

Categories

(Testing :: Marionette, defect)

defect
Not set
normal

Tracking

(firefox18 fixed, firefox19 fixed)

RESOLVED FIXED
mozilla19
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: jgriffin, Assigned: jgriffin)

Details

Attachments

(1 file)

This is due to my patch in bug 802807.  That patch breaks JS tests for desktop Firefox, since it attempts to wait for isSystemMessageListenerReady() even when not running on B2G, and it breaks emulator JS tests on TBPL, because that event is not fired after updating gecko in the emulator.
This patch fixes the problem by only waiting for this even on emulator startup.  Thus, it won't affect non-B2G tests, it won't affect tests that run on an already-running B2G device, and it won't break due to the fact that the message it listens for doesn't get fired after updating gecko in the emulator.

It also doesn't fail if the 30s timeout elapses; we just assume then that the even never got fired and continue anyway.  I _think_ this should take care of all the potential use cases.
Attachment #672929 - Flags: review?(mdas)
Comment on attachment 672929 [details] [diff] [review]
Only wait for system-message-listener-ready on emulator startup,

makes sense... I'd add a comment about why we're doing this in the code though, since it's not very obvious.
Attachment #672929 - Flags: review?(mdas) → review+
Comment added and pushed as https://hg.mozilla.org/mozilla-central/rev/85172b4eb961
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [automation-needed-in-aurora]
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.