803293 - Remove some old code from BrowserApp

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

Attachment: Remove some old code from BrowserApp

Since we're stubbing the about:home tab now, we don't need the extra code to fake the tab by updating the tab title or calling showAboutHome() in initializeChrome(). This will be taken care of us when we get the SELECTED TabEvent.

Doing this requires we call Tabs.registerOnTabsChangedListener() before initializeChrome() so it will get the tab events.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 672972 [details] [diff] [review]
Remove some old code from BrowserApp


>diff --git a/mobile/android/base/BrowserApp.java b/mobile/android/base/BrowserApp.java


>+            case SELECTED:
>+                if (Tabs.getInstance().isSelectedTab(tab)) {
>+                    if ("about:home".equals(tab.getURL()))
>                         showAboutHome();
>-                    else 
>+                    else
>                         hideAboutHome();
>-                    maybeCancelFaviconLoad(tab);
>                 }
>                 break;


>-            case SELECTED:
>-                if ("about:home".equals(tab.getURL()))
>-                    showAboutHome();
>-                else
>-                    hideAboutHome();
>-                break;


in the new code you put the showAboutHome/hideAboutHome block in an isSelectedTab check. Does that break anything?

Comment 2

[Brian Nicholson (:bnicholson)]

(In reply to Mark Finkle (:mfinkle) from comment #1)
> 
> in the new code you put the showAboutHome/hideAboutHome block in an
> isSelectedTab check. Does that break anything?

That change was only made for the SELECTED case, so that check should always evaluate to true.

Comment 3

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/8cab337969f3

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8cab337969f3