Closed Bug 803293 Opened 7 years ago Closed 7 years ago

Remove some old code from BrowserApp

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 19

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

Attachments

(1 file)

Since we're stubbing the about:home tab now, we don't need the extra code to fake the tab by updating the tab title or calling showAboutHome() in initializeChrome(). This will be taken care of us when we get the SELECTED TabEvent.

Doing this requires we call Tabs.registerOnTabsChangedListener() before initializeChrome() so it will get the tab events.
Attachment #672972 - Flags: review?(mark.finkle)
Comment on attachment 672972 [details] [diff] [review]
Remove some old code from BrowserApp


>diff --git a/mobile/android/base/BrowserApp.java b/mobile/android/base/BrowserApp.java


>+            case SELECTED:
>+                if (Tabs.getInstance().isSelectedTab(tab)) {
>+                    if ("about:home".equals(tab.getURL()))
>                         showAboutHome();
>-                    else 
>+                    else
>                         hideAboutHome();
>-                    maybeCancelFaviconLoad(tab);
>                 }
>                 break;


>-            case SELECTED:
>-                if ("about:home".equals(tab.getURL()))
>-                    showAboutHome();
>-                else
>-                    hideAboutHome();
>-                break;


in the new code you put the showAboutHome/hideAboutHome block in an isSelectedTab check. Does that break anything?
(In reply to Mark Finkle (:mfinkle) from comment #1)
> 
> in the new code you put the showAboutHome/hideAboutHome block in an
> isSelectedTab check. Does that break anything?

That change was only made for the SELECTED case, so that check should always evaluate to true.
Attachment #672972 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/8cab337969f3
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.