803335 - Fix Twitter built-in search engine URL

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Frank Yan (:fryn)]

Attachment: patch

We're using the wrong URL in our built-in Twitter search engine.
With our current URL, Twitter incorrectly parses any query that contains a space.
For example, typing "hello world" (excluding those quotation marks) results in the Twitter query: hello+world

We can easily fix this by changing the URL from:
https://twitter.com/search/{searchTerms}
to:
https://twitter.com/search?q={searchTerms}

Fixing this will also make search result page detection much easier if we ever need it.

Kev, could you make sure that doing this doesn't break anything on Twitter's end, i.e. Twitter still recognizing that the search came from Firefox?

Comment 1

[Matthew N. [:MattN]]

(In reply to Frank Yan (:fryn) from comment #0)
> Created attachment 672998 [details] [diff] [review]

You should move the parameter to a <Param> element because that's what it's meant for and it'll be consistent with our other default engines. (e.g. https://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/searchplugins/bing.xml#15 )

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 672998 [details] [diff] [review]
patch

I agree with Matt. Otherwise this looks fine, and obviously the result is nicer - but IIRC Twitter specifically asked us to use this URL, so we need to get sign-off from them.

Comment 3

[Frank Yan (:fryn)]

Attachment: patch v2

(In reply to Matthew N. [:MattN] from comment #1)

Oops! Good catch. I copied the line https://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/searchplugins/google.xml#20 which was the wrong example to use.

Comment 4

[Kev Needham [:kev]]

Received confirmation this eve from Twitter that this change is approved/encouraged.

Comment 5

[Frank Yan (:fryn)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ed5e25d980a

(In reply to Kev Needham [:kev] from comment #4)

Thanks for your help, Kev & Gavin & Matt! :)

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6ed5e25d980a