If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[socorro-crashstats] Not passing the search's signature through when clicking from Search within a report

VERIFIED FIXED

Status

Socorro
Webapp
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: stephend, Assigned: adrian)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 673035 [details]
Screenshot

STR:

1. Load http://crash-stats-new-dev.allizom.org/report/index/a96f8bc7-3eb4-4821-b1b7-62a0b2121018
2. Click on "Search" which links to http://crash-stats-new-dev.allizom.org/query?advanced=1&signature=js%3A%3AObjectImpl%3A%3AreadBarrier%28js%3A%3AObjectImpl%2A%29
3. From there, look at the textfield for "Stack signature"

Expected:

js%3A%3AObjectImpl%3A%3AreadBarrier%28js%3A%3AObjectImpl%2A%29 should be present

Actual:

It's not passed through to the textfield (compare to prod: https://crash-stats.mozilla.com/query?advanced=1&signature=js%3A%3AObjectImpl%3A%3AreadBarrier%28js%3A%3AObjectImpl*%29)
(Assignee)

Updated

5 years ago
Assignee: nobody → adrian
(Assignee)

Comment 1

5 years ago
PR: https://github.com/mozilla/socorro-crashstats/pull/207

Comment 2

5 years ago
Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/62b05841a1bbb9752ddfa04f9121c4a47e7245a1
Fixes bug 803371 - Use the signature parameter as a default value for the query field.

https://github.com/mozilla/socorro-crashstats/commit/c598749c33ac6e2f14c816064ecfdc7bfe07ed82
Merge pull request #207 from AdrianGaudebert/803371-report-index-link-to-search

Fixes bug 803371 - Use the signature parameter as a default value for th...

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

5 years ago
Verified FIXED:

1. Loading http://crash-stats-new-dev.allizom.org/report/index/25f1799f-d5ef-4693-980e-7fd5c2121023 and clicking on Search takes me to:
2. http://crash-stats-new-dev.allizom.org/query/?advanced=1&signature=mozalloc_abort%28char+const*+const%29+|+NS_DebugBreak_P+|+nsAString_internal%3A%3ASetCapacity%28unsigned+int%29

...which has the signature pre-filled.
Status: RESOLVED → VERIFIED
(Reporter)

Comment 4

5 years ago
Created attachment 674755 [details]
Post-fix screenshot
You need to log in before you can comment on or make changes to this bug.