The default bug view has changed. See this FAQ.

Only dereference the cookie value if it is not undefined

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

Trunk
Firefox 19
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(firefox17 fixed, firefox18 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

Created attachment 673059 [details] [diff] [review]
Patch

At http://hg.mozilla.org/mozilla-central/annotate/cf1bbed46731/toolkit/components/social/WorkerAPI.jsm#l72 we should only dereference the |value| variable if it is not undefined.

Using destructuring assignment, if the string doesn't contain an "=" character, then the |value| variable will have undefined.

This bug was fixed by the patch for bug 787767 on mozilla-central(19), so this patch is only designed for uplift to mozilla-aurora(18) and mozilla-beta(17).

On requesting uplift:
This is a minor code change that will only affect the Social API. This has been tested locally and is under test on mozilla-central. There are no expected regressions with this change and there are no string changes either.
Attachment #673059 - Flags: review?(felipc)
Attachment #673059 - Flags: approval-mozilla-beta?
Attachment #673059 - Flags: approval-mozilla-aurora?
Attachment #673059 - Flags: review?(felipc) → review+
Attachment #673059 - Flags: approval-mozilla-beta?
Attachment #673059 - Flags: approval-mozilla-beta+
Attachment #673059 - Flags: approval-mozilla-aurora?
Attachment #673059 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9af9ca79f026
https://hg.mozilla.org/releases/mozilla-aurora/rev/2a2a18c820c4
https://hg.mozilla.org/releases/mozilla-beta/rev/5152b00790f9
status-firefox17: --- → fixed
status-firefox18: --- → fixed
https://hg.mozilla.org/mozilla-central/rev/9af9ca79f026

Should this have a test?
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Tagging [qa-] as it appears the change here is low risk and doesn't need QA verification. Jared, please remove [qa-] and add the verifyme keyword if there's something you want tested here.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.