Closed Bug 803385 Opened 7 years ago Closed 7 years ago

Only dereference the cookie value if it is not undefined

Categories

(Firefox Graveyard :: SocialAPI, defect)

defect
Not set

Tracking

(firefox17 fixed, firefox18 fixed)

RESOLVED FIXED
Firefox 19
Tracking Status
firefox17 --- fixed
firefox18 --- fixed

People

(Reporter: jaws, Assigned: jaws)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch PatchSplinter Review
At http://hg.mozilla.org/mozilla-central/annotate/cf1bbed46731/toolkit/components/social/WorkerAPI.jsm#l72 we should only dereference the |value| variable if it is not undefined.

Using destructuring assignment, if the string doesn't contain an "=" character, then the |value| variable will have undefined.

This bug was fixed by the patch for bug 787767 on mozilla-central(19), so this patch is only designed for uplift to mozilla-aurora(18) and mozilla-beta(17).

On requesting uplift:
This is a minor code change that will only affect the Social API. This has been tested locally and is under test on mozilla-central. There are no expected regressions with this change and there are no string changes either.
Attachment #673059 - Flags: review?(felipc)
Attachment #673059 - Flags: approval-mozilla-beta?
Attachment #673059 - Flags: approval-mozilla-aurora?
Attachment #673059 - Flags: review?(felipc) → review+
Attachment #673059 - Flags: approval-mozilla-beta?
Attachment #673059 - Flags: approval-mozilla-beta+
Attachment #673059 - Flags: approval-mozilla-aurora?
Attachment #673059 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/9af9ca79f026

Should this have a test?
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Tagging [qa-] as it appears the change here is low risk and doesn't need QA verification. Jared, please remove [qa-] and add the verifyme keyword if there's something you want tested here.
Whiteboard: [qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.