803409 - Find a better fix for the workaround in bug 803170

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

See the discussion in that bug.  The mechanism that the settings app uses for transitions is a bit fragile, and was broken by bug 703241.

Comment 1

[Fabien Cazenave [:kaze]]

Agreed, we need another way to do these panel transitions — not only because of the viewport trick, but also because the transitions are really sketchy, see bug 796804.

Yesterday I spent most of my day trying to get smoother transitions, which will probably imply some JS to set a `display: none;' rule on all panels but the active and former active one…

If you have any suggestion to make these transitions more robust *and* smoother, I’m all ears. I’d prefer to stay on a purely declarative solution, but the priority is to get smooth/robust transitions here.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Fabien Cazenave [:kaze] from comment #1)
> Yesterday I spent most of my day trying to get smoother transitions, which
> will probably imply some JS to set a `display: none;' rule on all panels but
> the active and former active one…

If you are transitioning something from hidden, transition the |visibility| property instead of setting |display| before or after the transition. This is what I recently learned on the job, and I've even wrote a blog post about it!

http://blog.timc.idv.tw/posts/css-transition-on-visibility-property/

Comment 3

[Kevin Grandon :kgrandon]

With the recent work and AMD refactor this seems to be working fairly well now. Please reopen with more details if you think this is still an issue.