Using third party dependencies does not work

RESOLVED FIXED in 1.12

Status

Add-on SDK
General
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: erikvold, Assigned: erikvold)

Tracking

unspecified
1.12

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

If I have one dependency in the package.json (it exists, but is not used) then I get the following error:

(addon-sdk)server:amo-addon-tester erikvold$ cfx run
ModuleNotFoundError: unable to satisfy: require(preferences-service) from
  /Users/erikvold/github/amo-addon-tester/lib/main.js:3:
Looked for it in:
  /Users/erikvold/github/amo-addon-tester/lib/sdk/preferences/service.js
  /Users/erikvold/github/addon-sdk/packages/vold-utils/lib/sdk/preferences/service.js
Flags: needinfo?(rFobic)
Irakli wontfixed bug 663480 in May, which is what this is about.
Created attachment 674697 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/627

Pointer to Github pull-request
Flags: needinfo?(rFobic)
Attachment #674697 - Flags: review?(evold)

Updated

5 years ago
Priority: -- → P1
Comment on attachment 674697 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/627

This patch doesn't seem to work for me, see comments in pull request.
Attachment #674697 - Flags: review?(evold) → review-
Created attachment 685755 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/667

Pointer to Github pull-request
Attachment #685755 - Flags: review?(rFobic)
Assignee: nobody → evold
Comment on attachment 685755 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/667

Matteo can you have a look at this?  I think Mossop wants it for the rc2
Attachment #685755 - Flags: review?(rFobic) → review?(zer0)

Comment 7

5 years ago
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/2dbe714ce19e7945013ed82ebfd284cab390b4c5
Merge pull request #667 from erikvold/803417

fix Bug 803417 - support for packages with defined dependencies r=@gozala

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.12
Attachment #685755 - Flags: review?(zer0)

Comment 8

5 years ago
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/9c31911385c15801523dd6ca27bcc2a5748ff476
Merge pull request #667 from erikvold/803417

fix Bug 803417 - support for packages with defined dependencies r=@gozala(cherry picked from commit 2dbe714ce19e7945013ed82ebfd284cab390b4c5)
You need to log in before you can comment on or make changes to this bug.