803417 - Using third party dependencies does not work

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

If I have one dependency in the package.json (it exists, but is not used) then I get the following error:

(addon-sdk)server:amo-addon-tester erikvold$ cfx run
ModuleNotFoundError: unable to satisfy: require(preferences-service) from
  /Users/erikvold/github/amo-addon-tester/lib/main.js:3:
Looked for it in:
  /Users/erikvold/github/amo-addon-tester/lib/sdk/preferences/service.js
  /Users/erikvold/github/addon-sdk/packages/vold-utils/lib/sdk/preferences/service.js

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Irakli wontfixed bug 663480 in May, which is what this is about.

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/627

Pointer to Github pull-request

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

I've tried the pull request on https://github.com/erikvold/amo-addon-tester but I got the error I mention at https://github.com/mozilla/addon-sdk/pull/627#issuecomment-9880956

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 674697 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/627

This patch doesn't seem to work for me, see comments in pull request.

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/667

Pointer to Github pull-request

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 685755 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/667

Matteo can you have a look at this?  I think Mossop wants it for the rc2

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/2dbe714ce19e7945013ed82ebfd284cab390b4c5
Merge pull request #667 from erikvold/803417

fix Bug 803417 - support for packages with defined dependencies r=@gozala

Comment 8

[[github robot]]

Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/9c31911385c15801523dd6ca27bcc2a5748ff476
Merge pull request #667 from erikvold/803417

fix Bug 803417 - support for packages with defined dependencies r=@gozala(cherry picked from commit 2dbe714ce19e7945013ed82ebfd284cab390b4c5)