803449 - Unidentifiable toggle in the notification bar

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Dave Townsend [:mossop]]

One of the toggle buttons in the notification bar looks like a leaf. I have no idea what it is for.

Comment 1

[Chris Lee [:clee]]

+UX for feedback

I would agree that the majority of users will have no idea what 'leaf' means.

Comment 2

[Patryk Adamczyk [:patryk] UX]

(In reply to Dave Townsend (:Mossop) from comment #0)
> One of the toggle buttons in the notification bar looks like a leaf. I have
> no idea what it is for.

Its supposed to be "power conservation" there are 2 used metaphors in the industry. A light bulb or a leaf. We felt the light bulb would confuse users with brightness.

Comment 3

[Patryk Adamczyk [:patryk] UX]

+ Peter,
Perhaps we can integrate the battery and leaf together.
But I would still want to maintain the leaf in the icon.

Comment 4

[Mike Connor [:mconnor]]

Per triage: while the UX is not optimal in terms of discovery, it is something we can document well and leave to users to discover through the user guide.  Adding user-doc-needed and minusing.  If UX comes up with a better visual metaphor, we'll consider a fix.

Comment 5

[Dave Townsend [:mossop]]

What could help a lot here is including the leaf in the power saving section of settings, that way there is at least a link I can make without needing to read a user guide.

Comment 7

[Etienne Segonzac (:etienne)]

Attachment: The Icons

Comment 8

[Etienne Segonzac (:etienne)]

Peter made the icons, this polish bug is ready to be worked on.

Probably a bit more work than switching the images since it adds some logic depending the the network type.

Comment 9

[Peter La]

Hi Etienne, are you going to be doing the implementation for this?

Comment 10

[Etienne Segonzac (:etienne)]

(In reply to Peter La from comment #9)
> Hi Etienne, are you going to be doing the implementation for this?

Not allowed to work on blocking-minuses, but I would gladly review/help :)

Comment 11

[Peter La]

Sam Joch is assigned to this.  Is he actually working on it?  I just want to make sure this bug gets movement.  It's also overlapping with this bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=796420

Which has Yuren assigned to it... we need to figure out who is going to do this.

Comment 12

[Etienne Segonzac (:etienne)]

(In reply to Peter La from comment #11)
> Sam Joch is assigned to this.

Cool! I'll make sure to sync up with him on the subject early next week.

Comment 13

[Sam Joch [:samjoch]]

Is there a data-off icon without type (nether 2G, 3G, ...)  ? Or i just don't need it ?

Comment 14

[Dave Townsend [:mossop]]

Bad news ... http://www.theregister.co.uk/2012/12/10/apple_applies_to_trademark_the_leaf/

Comment 16

[Peter La]

Attachment: New Version of Icons

This new version of the icons has 2 changes:

1 Data-off state added (uses the transmission arrows).
2 Power saving icon removes the leaf in favor of a battery/cost savings metaphor.

Comment 17

[Sam Joch [:samjoch]]

Attachment: Branch on github

Comment 18

[Patryk Adamczyk [:patryk] UX]

Looks good overall, it appeared that the data off icon wasn't working in your branch yet. But once that is in, you can merge it.

Comment 19

[Sam Joch [:samjoch]]

Landed in UX Branch https://github.com/gordonbrander/gaia/commit/d1df9652f7780c6294641c26a562b4d399693f77

Comment 21

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

The icons look better.  the <> data one disappears after being tapped on though.  Becomes a usability issue.

Comment 22

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Still gone in today's build.  Looking at logcat I see : 
12-27 16:03:59.708: D/memalloc(108): /dev/pmem: Allocated buffer base:0x4ac00000 size:532480 offset:1228800 fd:110
12-27 16:03:59.718: D/memalloc(450): /dev/pmem: Mapped buffer base:0x43900000 size:1761280 offset:1228800 fd:38
12-27 16:03:59.728: D/memalloc(108): /dev/pmem: Allocated buffer base:0x4ac00000 size:532480 offset:1761280 fd:135
12-27 16:03:59.728: D/memalloc(450): /dev/pmem: Mapped buffer base:0x45900000 size:2293760 offset:1761280 fd:41
12-27 16:03:59.738: D/memalloc(108): /dev/pmem: Allocated buffer base:0x4ac00000 size:81920 offset:3719168 fd:139
12-27 16:03:59.738: D/memalloc(450): /dev/pmem: Mapped buffer base:0x45bd3000 size:3801088 offset:3719168 fd:44
12-27 16:04:00.038: E/memalloc(108): unrecognized pixel format: 8
12-27 16:04:00.038: W/GraphicBufferAllocator(108): alloc(54, 22, 8, 00000133, ...) failed -22 (Invalid argument)
12-27 16:04:00.048: D/memalloc(108): /dev/pmem: Allocated buffer base:0x4ac00000 size:8192 offset:3801088 fd:145
12-27 16:04:00.048: D/memalloc(450): /dev/pmem: Mapped buffer base:0x45f73000 size:3809280 offset:3801088 fd:48
12-27 16:04:00.048: E/memalloc(108): unrecognized pixel format: 8
12-27 16:04:00.048: W/GraphicBufferAllocator(108): alloc(54, 22, 8, 00000133, ...) failed -22 (Invalid argument)
12-27 16:04:00.068: E/memalloc(108): unrecognized pixel format: 9
12-27 16:04:00.068: W/GraphicBufferAllocator(108): alloc(54, 22, 9, 00000133, ...) failed -22 (Invalid argument)
12-27 16:04:00.068: I/Gonk(108): GraphicBufferAllocator::alloc failed
12-27 16:04:00.068: E/memalloc(108): unrecognized pixel format: 9
12-27 16:04:00.068: W/GraphicBufferAllocator(108): alloc(54, 22, 9, 00000133, ...) failed -22 (Invalid argument)
12-27 16:04:00.068: I/Gonk(108): GraphicBufferAllocator::alloc failed
12-27 16:04:00.108: D/memalloc(108): /dev/pmem: Allocated buffer base:0x4ac00000 size:8192 offset:3809280 fd:150
12-27 16:04:00.118: D/memalloc(450): /dev/pmem: Mapped buffer base:0x46315000 size:3817472 offset:3809280 fd:52
12-27 16:04:00.148: I/ONCRPC(112): rpc_handle_rpc_call: for Xid: 121, Prog: 31000000, Vers: fc37ad5c, Proc: 0000000e
12-27 16:04:00.148: I/ONCRPC(112): rpc_handle_rpc_call: Find Status: 0 Xid: 121
12-27 16:04:00.148: I/ONCRPC(112): oncrpc_proxy_handle_cmd_rpc_call: Dispatching xid: 121
12-27 16:04:00.519: D/memalloc(450): /dev/pmem: Unmapping buffer base:0x46315000 size:3817472 offset:3809280
12-27 16:04:00.519: D/memalloc(108): /dev/pmem: Freeing buffer base:0x4afa2000 size:8192 offset:3809280 fd:150
12-27 16:04:00.529: D/memalloc(108): /dev/pmem: Freeing buffer base:0x4afa0000 size:8192 offset:3801088 fd:145
12-27 16:04:00.529: D/memalloc(450): /dev/pmem: Unmapping buffer base:0x45f73000 size:3809280 offset:3801088


I'm guessing there might be a corrupt image?

Comment 23

[Sam Joch [:samjoch]]

i commited fixes Landed in UX Branch. https://github.com/gordonbrander/gaia/commit/fe9bdbd83e76121dc72fe5d5d7122b6dbd748a63

I noticed that the data button is not very responsive.

Comment 24

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Ok, I see the image; the functionality itself is busted.  It doesn't turn off/on on my build either.

Something happened in the UX branch that broke it.  It works fine in the main branch.

Comment 25

[Sam Joch [:samjoch]]

Ok, i split the network info from the data.enabled flag into another flag 'network'.
and change the listener on datachange to set up the network flag.

Now i kept the gaia/master behavior and updated the data network icon.

Commited in UX Branch https://github.com/gordonbrander/gaia/commit/21bc4674b6cf35d1b6a374884eed50b6d229f34d

Comment 26

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

A few comments:
Looks like that change fixed the issue in terms of functionality...

The line :  delete self.data.dataset.enabled; 
kinda worries me a little bit; I couldn't find anything immediate that caused an issue at this moment.

Also nuts... I looked at the code change and realized I have to be able to check all the variety of networks...

To note, when swapping the sims and looking at the icon ... I saw "<>" icon.  when the edge network for tmobile as well as AT&T came up, I saw "E" icon... I am not sure how I can get the other icons to appear without getting SIMS for each case...

Comment 27

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/66221e02ffcb370373544685b55218ecc506a482

Comment 28

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Master build : 2013-03-25-03-07-06
"mozilla-central" revision="bef19bca23f9"
"integration/gaia-central" revision="8c401e09a6a9"
"gecko.git"revision="bbaac6bbbf5084ef1a3e178ced676ea77db8b24b"
"gaia.git" revision="a1259a6c80629daa458428d6a96403841aaab0f0"

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/dec694d585e1
Gaia   5a31a56b96a8fc559232d35dabf20411b9c2ca1d
BuildID 20130325070203
Version 18.0
Unagi