803474 - [lock screen] animated arrows are sometimes visible shortly before unlocking

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

> .touched .lockscreen-arrow,
> #screen:not(.locked) .lockscreen-arrow {
>   display: none;
>   animation: none;
> }

The arrows are hidden while the handle is touched. On mouseup the 'touched' class is removed and a transitionend listener is registered that then unlocks the screen. While waiting for the transition to end the arrows become visible again depending on their current animation progress. The 'animation: none' rule doesn't take effect either because the class selector doesn't override the ID selector.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/5894

Pointer to Github pull-request

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 673139 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/5894

This a dup of Gecko bug 788412. A Gecko bug require Gecko fix. Your fix is good workaround but let's not merge it unless we cannot fix it on the Gecko side in time.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thank you for catching this and the quick fix :)

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Sorry, but please read the summary again. This is not a duplicate of bug 788412. Bug 788412 is about the arrows being drawn on top of the handler. This bug is about visible arrows between the unlock gesture and the actual unlock.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Sh*t, I overlook the description completely :-/ Sorry about that.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 673139 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/5894

Let me flag you for review again ;)

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 673139 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/5894

The part I don't like is the !important part, but I guess it's OK.

Can you fill the form below if vingtetun need that?

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Thank you, Tim! (I always wanted to say that.)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Arrows may flash before unlocking.
Testing completed: 
Risk to taking this patch (and alternatives if risky): Small, almost CSS-only fix.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #7)
> Comment on attachment 673139 [details]
> Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/5894
> 
> The part I don't like is the !important part, but I guess it's OK.
> 

I feel like you with the !important. It make debug painful and usually hide deeper issue.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 673139 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/5894

Anyway a=me since Tim r+ it and this only add/remove a class.

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Vivien Nicolas (:vingtetun) from comment #9)
> > The part I don't like is the !important part, but I guess it's OK.
> 
> I feel like you with the !important. It make debug painful and usually hide
> deeper issue.

I updated the PR and removed the !important. We need to use the IDs #lockscreen-left-arrow and #lockscreen-right-arrow to get rid of it.

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/pull/5894

Merged.

Comment 13

[Deepa Subramanian]

The lock screen has been redesigned and this bug is no longer valid. Verified on Unagi build id:20130102070202