803558 - Update manifest checking to retry before throwing to re-review

Status: RESOLVED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P3)

Description

[Rob Hudson [:robhudson]]

Problem:
There are a lot of hosted apps whose manifests are unavailable for whatever network reason when the crons check them daily. This results in ~75% of the re-review queue being populated by apps that, when manually checked by the reviewers, are fine.

Idea for solution:
Update this task to retry in an hour if it fails the first time. If retry count is 3 (we've checked it 3 times and it is still failing), throw it into the re-review queue.

Notes:
Celery seems to be able to handle this... tasks have a retry call that takes a countdown arg (in seconds). Tasks also keep track of their retries available in `task.request.retries` it looks like.

The current code lives here:
https://github.com/mozilla/zamboni/blob/master/mkt/webapps/tasks.py
L88 is where we are currently throwing it to re-review whenever there is any exception in fetching the manifest.

Comment 1

[Allen Short [:ashort]]

https://github.com/mozilla/zamboni/commit/f8eb5f57fb
https://github.com/mozilla/zamboni/commit/b4ca832c17