803571 - Clear private data not always clearing about:home entries/thumbnails

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently, when one clears private data (all popup menu item entries checked), returns to about:home, entries for websites that should have been cleared still persist (along their thumbnails).

I think this might be a regression.

--
Samsung Galaxy Nexus (Android 4.1.2)
Nightly (10/19)

Comment 1

[Aaron Train [:aaronmt]]

Steps to reproduce:

1) New profile, visit http://www.yahoo.com in one tab, and http://www.bing.com in another
2) Verify new entries and thumbnails on about:home, and then clear private data
3) Verify new entries and thumbnails on about:home are now cleared

--

4) Refresh the http://www.yahoo.com tab, refresh the http://www.bing.com tab
5) Verify the new entries and thumbnails are back on about:home, and then clear private data
6) Verify new and thumbnails still show up on about:home

Comment 2

[Aaron Train [:aaronmt]]

Probably a regression from the new thumbnails on about:home

Comment 3

[Paul Feher]

The possible regression window for this issue is:

good build:
2012/09/25

bad build 
2012/09/26

possible push-log:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=08d435dedc7f&tochange=ca4af4af5334

NOTE: I've encountered this issue for older build but is not reproducible 100% and it appears after several tries so it's very hard to find a regression window. Starting the Nightly build from 2012/09/26 the bug is 100% reproducible.

Comment 4

[Aaron Train [:aaronmt]]

Need a smaller window

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

bug 789887 seems suspicious. CC'ing LucasR as he reviewed the code and Margret is on loan to b2g.

Comment 6

[Lucas Rocha (:lucasr)]

Attachment: Clear database before refreshing about:home

Comment 7

[Adrian Tamas (:AdrianT)]

Test case added for this scenario in Moztrap: https://moztrap.mozilla.org/manage/cases/_detail/11111/

Comment 8

[Adrian Tamas (:AdrianT)]

Removing regression-wanted since a fix has been proposed for the issue

Comment 9

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/f4f0e94fa957

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f4f0e94fa957

Comment 11

[Adrian Tamas (:AdrianT)]

I am unable to reproduce the issue on Aurora 19.0a2 2012-11-25 and Nightly 20.0a1 2012-11-25 on the Asus EEE Transformer running Android 4.0.3 following the steps from Comment 1. Marking the issue as verified.

Comment 12

[Aaron Train [:aaronmt]]

Karen ran into this today on 18; despite this being marked unaffected. Do we want to uplift?

Comment 13

[Scoobidiver (away)]

(In reply to Aaron Train [:aaronmt] from comment #12)
> Karen ran into this today on 18; despite this being marked unaffected. Do we
> want to uplift?
The regression window in comment 3 shows it first occurred in 18.0.

Comment 14

[Lucas Rocha (:lucasr)]

(In reply to Aaron Train [:aaronmt] from comment #12)
> Karen ran into this today on 18; despite this being marked unaffected. Do we
> want to uplift?

FWIW, this patch is small and very low risk.

Comment 15

[Aaron Train [:aaronmt]]

This seems to be an issue once again on Nightly. Shall we re-open this for investigation?

Comment 16

[Aaron Train [:aaronmt]]

The case seems to be now; clear private data has no effect on the thumbnails on about:home

Comment 17

[bhavana bajaj [:bajaj]]

Tracking it for 18 as the patch looks simple and is a regression in 18.Please uplift the patch for beta approval to make it into beta 5.

Comment 18

[bhavana bajaj [:bajaj]]

(In reply to Lucas Rocha (:lucasr) from comment #9)
> Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/f4f0e94fa957

Lucas, can we please nominate patches for branch uplifts ?

Comment 19

[bhavana bajaj [:bajaj]]

(In reply to Aaron Train [:aaronmt] from comment #15)
> This seems to be an issue once again on Nightly. Shall we re-open this for
> investigation?

Aaron can you please confirm if the issue persists on beta/aurora ? The status flag indicates that aurora is verified and beta affected.May be double checking here will be helpful.

Comment 20

[Aaron Train [:aaronmt]]

I'm actually not able to reproduce at all anymore on any channel; no idea why or what fixed this.

Comment 21

[Lucas Rocha (:lucasr)]

Comment on attachment 678719 [details] [diff] [review]
Clear database before refreshing about:home

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: Start page might not be properly cleared after user cleans all personal data from profile.
Testing completed (on m-c, etc.): It's been in m-c for some time now.
Risk to taking this patch (and alternatives if risky): Very low, tiny patch.
String or UUID changes made by this patch: none.

Comment 22

[Scoobidiver (away)]

The patch landed when Nightly was in 19.0 so there's no need to uplift it to Aurora 19.

Based on comment 20, I assume it's fixed.

Comment 23

[bhavana bajaj [:bajaj]]

Comment on attachment 678719 [details] [diff] [review]
Clear database before refreshing about:home

This is verified on aurora, hence not needed.Looking at the patch it seems pretty safe land on beta.

Comment 24

[Ioana Chiorean]

Firefox 20.0a1 (2012-11-18)
Device: Galaxy Nexus
OS: Android 4.1.1 

This is not reproducible on latest Nightly nor Aurora. 
I will wait for 18 beta 5 to validate this on beta channel too.

Comment 25

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/releases/mozilla-beta/rev/43c6663e0165

Comment 26

[Adrian Tamas (:AdrianT)]

This is still an issue on Firefox Mobile 18 beta 5. The patch may not have made it into beta 5 so leaving this open to test on Beta 6

Comment 27

[Scoobidiver (away)]

(In reply to adrian tamas from comment #26)
> The patch may not have made it into beta 5
Yes, indeed. See http://hg.mozilla.org/releases/mozilla-beta/graph

Comment 28

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/43c6663e0165

Comment 29

[Ioana Chiorean]

Firefox 18.0b6 (2012-12-27)
Device: Galaxy Nexus/ Tab 
OS: Android 4.1.1/ 3.1

This feature is not reproducible on Firefox 18 Beta 6 so I will set the flag to fixed. can someone with a B2G phone verify it too? Thanks.

Comment 30

[Andrei Boros]

Device: Allview Cosmote MyMini Tab
OS: Android 4.1
Firefox: 21.0

"Clear Private Data" command does not properly clear the home screen (Top sites). 
The website thumbnails dissapear (except for the thumbnail of firefox add-ons website) but the links and page titles remain. 

Reproductible: always

Please REOPEN.

Comment 31

[Adrian Tamas (:AdrianT)]

Hi Andrei,

Please note that clearing private data does not remove the bookmarks and pinned sites which will be displayed in the Top Sites list and eventually the first 6 bookmarks will be displayed on about:home. 

Can you make sure you have no pinned websites on about:home and see if clearing the private data clears the about:home content leaving only the bookmarks displayed. If you can reproduce this on your device please file a separate bug and try to add a screenshot of about:home after private data cleared to the bug.

Thanks,
Adrian

Comment 32

[Andrei Boros]

Hi,

I never use the "top sites" screen actually on the desktop or mobile. 
On the Android tablet, it is just there (haven't found a way to deactivate it yet), so you can be sure that I haven't bookmarked intentionally any URL. 
And the sites displayed there are actually the last few sites that I have visited recently.

I always search or enter the URL. Always. 
Clearing private data and having these on the opening screen of Firefox is baffling and definitely not private. 

As a comparison, Dlphin browser on Android does not leave such info. 

Thank you.

Comment 33

[Andrei Boros]

Unfortunately my tablet just left me for a couple of weeks for repairs under warranty, but I will document things in detail afterwards.