803613 - java.lang.NullPointerException: at org.mozilla.gecko.gfx.ScreenshotLayer$ScreenshotImage.setBitmap(ScreenshotLayer.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Scoobidiver (away)]

It first appeared in 19.0a1/20121019 and has been hit by two users. The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cb573b9307e5&tochange=0ff60bfb3442

Here is a crash report: bp-c7858491-7894-4bb1-94b2-4e8932121019.

java.lang.NullPointerException
	at org.mozilla.gecko.gfx.ScreenshotLayer$ScreenshotImage.setBitmap(ScreenshotLayer.java:146)
	at org.mozilla.gecko.gfx.ScreenshotLayer.setBitmap(ScreenshotLayer.java:42)
	at org.mozilla.gecko.gfx.LayerRenderer.setCheckerboardBitmap(LayerRenderer.java:131)
	at org.mozilla.gecko.ScreenshotHandler$2.run(ScreenshotHandler.java:355)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:31)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.gfx.ScreenshotLayer%24ScreenshotImage.setBitmap%28ScreenshotLayer.java%29

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Likely a regression from bug 779511. Looks like a race - the screenshot bitmap is coming in after the screenshot layer is destroyed. I'll put together a fix.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: NPE fix

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Minor cleanup

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4fa894b7348
https://hg.mozilla.org/integration/mozilla-inbound/rev/666a61b83149

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e4fa894b7348
https://hg.mozilla.org/mozilla-central/rev/666a61b83149