Closed Bug 803724 Opened 7 years ago Closed 7 years ago

[OS X] Text of some toolbar icons are not lined up

Categories

(Thunderbird :: Theme, defect)

x86
macOS
defect
Not set

Tracking

(thunderbird17 fixed, thunderbird18 fixed)

RESOLVED FIXED
Thunderbird 19.0
Tracking Status
thunderbird17 --- fixed
thunderbird18 --- fixed

People

(Reporter: Nomis101, Assigned: Paenglab)

References

Details

Attachments

(2 files, 2 obsolete files)

Attached image Screenshot of the issue
In the monochrom toolbar on OS X, the text of some toolbar icons is a bit too far up. In the Screenshot its the button for Chat and File.
Attached patch patch (obsolete) — Splinter Review
Make the rule less specific.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #673548 - Flags: review?(mconley)
Attached patch patch (obsolete) — Splinter Review
Better patch
Attachment #673548 - Attachment is obsolete: true
Attachment #673548 - Flags: review?(mconley)
Attachment #673549 - Flags: review?(mconley)
Attached patch correct patchSplinter Review
Oops, previous patch was a wrong one. Now the correct patch, I promise.
Attachment #673549 - Attachment is obsolete: true
Attachment #673549 - Flags: review?(mconley)
Attachment #673550 - Flags: review?(mconley)
Comment on attachment 673550 [details] [diff] [review]
correct patch

Review of attachment 673550 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks Richard!
Attachment #673550 - Flags: review?(mconley) → review+
Keywords: checkin-needed
Comment on attachment 673550 [details] [diff] [review]
correct patch

[Approval Request Comment]
This is only a small CSS patch. With the now long cycles it would land on TB24 to the end user.
Attachment #673550 - Flags: approval-comm-beta?
Attachment #673550 - Flags: approval-comm-aurora?
https://hg.mozilla.org/comm-central/rev/5ba5d4c61642
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
Attachment #673550 - Flags: approval-comm-beta?
Attachment #673550 - Flags: approval-comm-beta+
Attachment #673550 - Flags: approval-comm-aurora?
Attachment #673550 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.