Note: There are a few cases of duplicates in user autocompletion which are being worked on.

[OS X] Text of some toolbar icons are not lined up

RESOLVED FIXED in Thunderbird 19.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Nomis101, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 19.0
x86
Mac OS X
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird17 fixed, thunderbird18 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Created attachment 673464 [details]
Screenshot of the issue

In the monochrom toolbar on OS X, the text of some toolbar icons is a bit too far up. In the Screenshot its the button for Chat and File.
(Assignee)

Comment 1

5 years ago
Created attachment 673548 [details] [diff] [review]
patch

Make the rule less specific.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #673548 - Flags: review?(mconley)
(Assignee)

Comment 2

5 years ago
Created attachment 673549 [details] [diff] [review]
patch

Better patch
Attachment #673548 - Attachment is obsolete: true
Attachment #673548 - Flags: review?(mconley)
Attachment #673549 - Flags: review?(mconley)
(Assignee)

Comment 3

5 years ago
Created attachment 673550 [details] [diff] [review]
correct patch

Oops, previous patch was a wrong one. Now the correct patch, I promise.
Attachment #673549 - Attachment is obsolete: true
Attachment #673549 - Flags: review?(mconley)
Attachment #673550 - Flags: review?(mconley)
Comment on attachment 673550 [details] [diff] [review]
correct patch

Review of attachment 673550 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks Richard!
Attachment #673550 - Flags: review?(mconley) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

5 years ago
Comment on attachment 673550 [details] [diff] [review]
correct patch

[Approval Request Comment]
This is only a small CSS patch. With the now long cycles it would land on TB24 to the end user.
Attachment #673550 - Flags: approval-comm-beta?
Attachment #673550 - Flags: approval-comm-aurora?
https://hg.mozilla.org/comm-central/rev/5ba5d4c61642
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
Attachment #673550 - Flags: approval-comm-beta?
Attachment #673550 - Flags: approval-comm-beta+
Attachment #673550 - Flags: approval-comm-aurora?
Attachment #673550 - Flags: approval-comm-aurora+
https://hg.mozilla.org/releases/comm-aurora/rev/310686c456d9
https://hg.mozilla.org/releases/comm-beta/rev/5ebfbccd7efb
status-thunderbird17: --- → fixed
status-thunderbird18: --- → fixed
You need to log in before you can comment on or make changes to this bug.