Closed Bug 803733 Opened 8 years ago Closed 8 years ago
Remove the hack around otoro orientation issue when capturing still images
We should normalize all these device quirks at the platform level. We've already busted another device from the hack.
PR for gaia portion: https://github.com/mozilla-b2g/gaia/pull/5909
This blocks correctly-oriented photos on the commercial phone.
blocking-basecamp: ? → +
Attachment #673505 - Flags: review?(jones.chris.g)
Attachment #673505 - Flags: review?(jones.chris.g) → review+
The PR of course looks fine, but please give us until Monday to land until we can work out something for otoro/unagi dogfooders. Sorry about that.
Carrying r+ forward
Attachment #673505 - Attachment is obsolete: false
Comment on attachment 674898 [details] [diff] [review] Trivial rebase nm. can't drive hg properly yet...
Attachment #674898 - Attachment is obsolete: true
Note to Moz dogfooders / bisecters: this patch and the associated gaia commit will result in rotated images being captured by the cameras on otoro and unagi. That's 100% expected and understood. You won't see this bug in full flashes. mvines was kind enough to land that workaround for us. However, we need to ship this workaround in a FOTA update to dogfooders. (Or have them push a new file to device.)
I'll land this on Aurora after it lands on m-c. No need to request checkin on that part as long as it's got blocking-basecamp+ or approval-aurora+.
(In reply to Chris Jones [:cjones] [:warhammer] from comment #11) > ... land that workaround for us. Ref: https://github.com/mozilla-b2g/android-device-otoro/commit/b456d081241f5c4bbf13d8f0e79ab140cc45a4f1 https://github.com/mozilla-b2g/android-device-unagi/commit/86e1911d940f1cfdad661603a305d07f3d041bb8
Also FTR, the FOTA wheels are in motion.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Duplicate of this bug: 805737
Duplicate of this bug: 805782
Duplicate of this bug: 806356
Defect is verified as fixed using the Unagi device, build 20130114073222. Needs to be verified on an Otoro device.
You need to log in before you can comment on or make changes to this bug.