Marketplace not respecting user's language set in preference and intl.accept_languages list

RESOLVED FIXED

Status

Marketplace
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: petercpg, Assigned: andym)

Tracking

Points:
---

Details

Marketplace is always displayed in zh-CN while intl.accept_languages is set to "zh-tw, zh, en-us, en", with the language is set to English (US) in settings.

Languages could be switched correctly in account settings when intl.accept_languages was set to only "en-us, en".

Tested on latest Firefox desktop, fennec 19.0a1 nightly, and android 4.0 stock browser (all in zh-TW).
Can you add a screenshot and a link?  You're seeing the marketplace in Chinese?  That shouldn't happen at all...
(Assignee)

Comment 2

5 years ago
I added in explicit lookup of some language codes, using shorter language codes:

https://github.com/mozilla/zamboni/blob/master/lib/settings_base.py#L126

That is being added, when it shouldn't be.

Setting that value to mkt/settings.py

SHORTER_LANGUAGES = {'en': 'en-US', 'pt': 'pt-PT'}

Should stop it doing that, when the relevant translations come in, we can add those back in.
Assignee: nobody → amckay
(Assignee)

Comment 3

5 years ago
https://github.com/mozilla/zamboni/commit/a89bde
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.