803875 - WebRTC crash [@sipcc::MediaConstraints::buildArray]

Status: VERIFIED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Christoph Diehl [:posidron]]

Attachment: callstack

Run: media/webrtc/signaling/test/signaling_unittests --gtest_filter=SignalingTest.CreateOfferNoVideoStream

Comment 1

[Ethan Hugg [:ehugg]]

Attachment: MediaConstraints - off-by-one error in sstrncpy calls

Comment 2

[Ethan Hugg [:ehugg]]

Comment on attachment 673986 [details] [diff] [review]
MediaConstraints - off-by-one error in sstrncpy calls


Length passed into sstrncpy should be the same as the buffer size.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Recently introduced bug; no sec-approval needed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a1925dde08ba

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a1925dde08ba

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So does our existing unit test cover this change?

Comment 6

[Christoph Diehl [:posidron]]

media/webrtc/signaling/test/signaling_unittests.cpp:547

    ASSERT_EQ(pc->CreateAnswer(constraints, NS_OK);

misses a ')'

Comment 7

[Ethan Hugg [:ehugg]]

This was fixed last night in a patch to Bug 729541


(In reply to Christoph Diehl [:cdiehl] from comment #6)
> media/webrtc/signaling/test/signaling_unittests.cpp:547
> 
>     ASSERT_EQ(pc->CreateAnswer(constraints, NS_OK);
> 
> misses a ')'

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Fixed in https://hg.mozilla.org/integration/mozilla-inbound/rev/5bd4c4bac9f1

Comment 9

[Jason Smith [:jsmith]]

The comments above imply the unittest was fixed. Not crashtest worthy, as a unit test already covers this.

Comment 10

[Al Billings [:abillings - ex-MoCo]]

Marking as status "disabled" for 18 since that's what we do for WebRTC issues that are pref'd off in 18.