803881 - WebRTC unit-test crash [@AudioSendAndReceive::GenerateAndReadSamples]

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Christoph Diehl [:posidron]]

Attachment: callstack

Run: <obj_dir>/media/webrtc/signaling/test/mediaconduit_unittests --gtest_filter=TransportConduitTest.TestDummyAudioWithTransport

This looks like a bug in the unit test itself, we need to fix this to run the tests accordingly.

media/webrtc/signaling/test/mediaconduit_unittests.cpp:304
...
   do
   {
    if(!memcpy(audioInput, inbuf, sampleLengthInBytes))
    {
      return;
    }
...

Comment 1

[Christoph Diehl [:posidron]]

Looks like sampleLengthInBytes is by +1 too large here?

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Fix wrong number of samples for webrtc media unit tests

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 673770 [details] [diff] [review]
Fix wrong number of samples for webrtc media unit tests

https://hg.mozilla.org/integration/mozilla-inbound/rev/414e2834bbdc

Comment 4

[Christoph Diehl [:posidron]]

Path did not fix the problem, tested with mc-inbound changeset: 111290:414e2834bbdc

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/414e2834bbdc