803937 - Week view - Events that span more than one day time-wise (e.g. 10/20 2am - 10/21 5am) show two instances of the event ending, both cases in which the time ending is incorrect

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P2)

Description

[Jason Smith [:jsmith]]

Build:

Device - Otoro

Hashes:

  <project name="gaia" path="gaia" remote="b2g" revision="f08661db7f19cf84e7ede83c360430f0b20bbbd2"/>
  <project name="releases-mozilla-aurora" path="gecko" remote="mozilla" revision="83ade3896454efca57cfabbb168873ab7709ab51"/>

Steps:

1. Create an event from 10/20/2012 5pm - 10/23/2012 4pm
2. View the event timeframe in the week view

Expected:

The event should be shown starting on 5pm on 10/20, spanning to the end of 10/20. Then, 10/21 and 10/22 should show it as an all-day event. On 10/23, we should see the event start from the beginning of the day until 4pm that day.

Actual:

The event appears to end twice when seen from the week view:

- 10/20/2012 at around 11:45pm
- 10/23/2012 at around 3:30pm

This isn't right.

Comment 1

[Jason Smith [:jsmith]]

Looks like this also happens with Nov 3rd 2am - Nov 4th 5am in the week view. Are we not blocking off the right amount of space for events in the week view that span more than one day?

Comment 2

[David Scravaglieri [:scravag]]

Need UX input on this

Comment 3

[James Lal [:lightsofapollo]]

Could I get a screenshot? This is likely a css/height bug if I am understanding this correctly.

Comment 4

[Jason Smith [:jsmith]]

Attachment: Event Info

Comment 5

[Jason Smith [:jsmith]]

Attachment: Week View - Wrong Time at End of Day

Comment 6

[Jason Smith [:jsmith]]

(In reply to James Lal [:lightsofapollo] from comment #3)
> Could I get a screenshot? This is likely a css/height bug if I am
> understanding this correctly.

Added screenshots. Sounds like it. After testing this a few times, the bug appears to happen in any case where the length of time of the event spans a long timeframe within a particular day (i.e. the block of time). In this instance, you see that we aren't filling the block all the way to the 12am piece to signify end of day. Another example you'd see this that's not an end of day example would be just create an event that spans 12 hours within the same day - you'll see similar behavior with the bottom portion of the block not extending entirely to the correct hour.

Based on the sound of the bug also, I don't think UX input is needed here. This sounds like a "fix the block height" bug for week view event hour blocks.

Comment 7

[Les Orchard [:lorchard]]

Going to try taking a crack at this.

Comment 8

[Les Orchard [:lorchard]]

Quick comment: Through trial-and-error, I worked out that the total element style height of a proper-looking bar from 12:00am to 11:59pm in a day is 2480%

Seems like the intent is for that to be 2400%, representing 100% per hour. So, the CSS seems somewhere to be chewing up ~3.3333% per hour (ie. 103.33333 * 24 = ~2480). 

I haven't yet worked out why that's happening in CSS, but have a tweak on the JS side which takes the discrepancy into account. This works but feels... wrong.

Comment 9

[Les Orchard [:lorchard]]

Okay, I think I worked it out. There's a 1px top and bottom margin on every ol in week_view.css, line 101:

#week-view .week-events > ol {
...
  margin: 1px;
...
}

So, if I set the bar height to `calc(1400% + 28px)`, I get a bar that's the correct height for 2pm. That seems still kind of dirty, but less hard coded and maybe more robust

Comment 10

[James Lal [:lightsofapollo]]

I think that's an acceptable fix for now as long as we comment on why we need it.

Comment 11

[Les Orchard [:lorchard]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6252

Pointer to Github pull-request

Comment 12

[Les Orchard [:lorchard]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6252#attch-to-bugzilla

Pointer to Github pull-request

Comment 13

[Les Orchard [:lorchard]]

Hmm, not sure why that happened twice, but look at me trying out the bugzilla addon

Comment 14

[Alex Keybl [:akeybl]]

Milestoning for C2 (deadline of 12/10), as this meets the criteria of "known P2 bugs found before or during C1".

Comment 15

[Dietrich Ayala (:dietrich)]

Les, did this land? Can this bug be closed?

Comment 16

[James Lal [:lightsofapollo]]

This landed awhile ago, sorry I probably should have closed this!