803938 - Building Blocks: List dialog are misaligned and overlap text in various apps

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Jason Smith [:jsmith]]

Attachment: Select dialog screenshot

Build:

Device - Otoro

Hashes

  <project name="gaia" path="gaia" remote="b2g" revision="f08661db7f19cf84e7ede83c360430f0b20bbbd2"/>
  <project name="releases-mozilla-aurora" path="gecko" remote="mozilla" revision="83ade3896454efca57cfabbb168873ab7709ab51"/>

Steps:

1. Go to the calendar settings (menu --> the wheel thing)
2. Select the select dialog in the sync calendar UI

Expected:

A select dialog should appear that does not mash text together all over the place.

Actual:

See screenshot. The text appears to be getting mashed all over the place here.

Comment 1

[Tony Chung [:tchung]]

Attachment: screenshot

This actually affects every select dialog box in all apps, that is using this format.  is this a building block bug?    Do we already have a dupe of this bug anywhere?   

Other areas this happens:
- email setup > select an imap or active sync type
- settings > regional selection
- settings > language selection
- settings > screen timeout
etc..

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This is a building block bug.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

After checking with Alive, this should be related to this rule in switches.css (included in system app).

label:not([for]) {
    display: inline-block;
    height: 5rem;
    position: relative;
    vertical-align: middle;
    width: 5rem;
}

Comment 5

[Mike Connor [:mconnor]]

Blocking+ based on the extent to which this impacts all apps using this building block.

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi Ismael,

Could you help check this building block related issue?
Thank you.

Comment 11

[Ismael Gonzalez [:basiclines]]

We will need to add to each label in the value selector the attribute "for" for avoiding getting the switches style.
If do you need help with this ping me via skype/irc

Thx!

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: pull request 6020

Add "for" attribute to the label element in value selector to avoid applying a general rule in building blocks

Comment 13

[Robert Kaiser]

This also happens in any web app that has a <select> in it, currently this is one of the most annoying bugs we have.

Comment 15

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

pull request 6020 r+ and merged.

Comment 17

[Jason Smith [:jsmith]]

This isn't fixed - tested this with the test case in comment 0 on the 10/29 build and I definitely am still getting a reproduction with the exact screenshot seen. Reopening.

Comment 18

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I could not reproduce this issue with today's build, 10/29.
  This should be a pure Gaia fix, and the gaia commit is:
    f18958076b2b50edf01754bb4934c998259ce6a2

Hi Jason,

Could you please provide the Gaia commit that you tested?
Thank you.

Comment 19

[Jason Smith [:jsmith]]

Gaia commit: ddafa86fc92914306be99c8458362cfc96d44e25

Comment 20

[Jason Smith [:jsmith]]

Oh I think I know what happened here. The commit I'm referencing is using a 10/26 nightly build. So it's a build mistake on my end.

Comment 21

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi Jason,

Thanks for the info and your help to verify this.
:)

Comment 22

[Jason Smith [:jsmith]]

Verified with the right build this time.