80399 - Radiogroup not able to get the value attribute of the default radio item

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[racham]

Radiogroup widget is not able to get the value of the default radio item in 
the group when queried for Radiogroup.value

Here is the situation

in xul : 
<radiogroup id="foo">
  <radio group="foo" value="bar1" label="test1" checked="true"/>
  <radio group="foo" value="bar2" label="test2"/>
</radiogroup>

in js (say in onInt()) :

when I do 

var serverTypeRadioGroup = document.getElementById("foo");
dump("default value = " + serverTypeRadioGroup.value + "\n");

I would expect it to print 'bar1' as that is the value of the default radio item 
(as checked attribute is set to true there).

instead, I have to do some thing like this for that to happen

serverTypeRadioGroup.value = 
serverTypeRadioGroup.selectedItem.getAttribute("value");
dump("default value = " + serverTypeRadioGroup.value + "\n");

Comment 1

[racham]

Withtout the hack I mentioned in the previous update, radiogroup waits for user 
to make explicit selection of one of radio items to give a valid value for 
radiogroup.value query.

Comment 2

[HJ]

Why don't you use something like this:

var serverTypeRadioGroup = document.getElementById("foo").selectedItem;
dump("default value = " + serverTypeRadioGroup.value + "\n");

'value' is a method so you don't need element.getAttribute('value') just use
element.value for it.

Comment 3

[HJ]

Attachment: small testcase/example

Comment 4

[David Hyatt]

Seems busted.  Ben, you can whip up a fix for this in no time.

Comment 5

[HJ]

I have a patch for this, but should this be done in radio.xml or radioBindings.xml ?

Comment 6

[HJ]

if i apply the patch to /xpfe/global/resources/content/bindings/radio.xml then
this problem is fixed. Will make a diff -u after cvs update. brb.

Comment 7

[HJ]

Attachment: testcase for the patch, hang on...

Comment 8

[HJ]

Attachment: apply this patch and the above testcase will show bar2

Comment 9

[David Hyatt]

Ben should sr... I don't remember why you would need this...

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 34295 [details] [diff] [review]
apply this patch and the above testcase will show bar2

sr=[e-mail]

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

patch, -> .9.9

Comment 12

[Blake Ross]

-->me

Comment 13

[Blake Ross]

Fixed.