Closed
Bug 804166
Opened 13 years ago
Closed 12 years ago
[Settings] Device Storage Memory Usage Bar Needs Redesign
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect, P3)
Tracking
(b2g18+ affected)
VERIFIED
FIXED
People
(Reporter: pla, Assigned: pivanov)
Details
(Whiteboard: visual design UX-P3 yedo, )
Attachments
(4 files, 2 obsolete files)
screenshot
The green memory usage bar needs to be redesigned to line up with our look and feel. It's currently a bit too 'pill' like in its shading.
|
||
Updated•13 years ago
|
Component: Gaia → Gaia::Settings
|
|
||
Comment 1•13 years ago
|
||
Doesn't follow our visual aesthetic, its worth looking at the progress bar.
Priority: -- → P3
|
|
||
Updated•13 years ago
|
Whiteboard: visual design → visual design, incorrect implementation
|
|
||
Updated•13 years ago
|
Keywords: polish
Whiteboard: visual design, incorrect implementation → visual design UX-P3 yedo
Use this updated version for implementation.
Attachment #705492 -
Attachment is obsolete: true
Hi Sam or Pavel, can one of you take this bug and implement it? Let me know how you want the final graphical assets to be delivered.
|
|
Assignee | |
Updated•13 years ago
|
Assignee: pla → pivanov
|
|
Assignee | |
Comment 5•13 years ago
|
||
Attachment #705797 -
Flags: review?(sjochimek)
|
|
||
Comment 6•13 years ago
|
||
Comment on attachment 705797 [details]
patch for UX branch
Review on github https://github.com/gordonbrander/gaia/pull/106/files
|
|
Assignee | |
Comment 7•13 years ago
|
||
sorry for the mistake Sam :) now it's ok I think :)
|
|
||
Updated•13 years ago
|
Whiteboard: visual design UX-P3 yedo → visual design UX-P3 yedo, uxbranch, landed in uxbranch
|
|
||
Comment 8•13 years ago
|
||
Comment on attachment 705797 [details]
patch for UX branch
landed in uxbranch: https://github.com/gordonbrander/gaia/commit/3be5adfcb49c9cb8674215990818acca5f229937
Attachment #705797 -
Flags: review?(sjochimek) → review+
|
|
||
Comment 9•13 years ago
|
||
Comment on attachment 705797 [details]
patch for UX branch
Vivien: Ux PR https://github.com/mozilla-b2g/gaia/pull/8164 ;-)
Attachment #705797 -
Flags: feedback?(21)
|
||
Comment 10•13 years ago
|
||
(In reply to Sam Joch [:samjoch] from comment #9)
> Comment on attachment 705797 [details]
> patch for UX branch
>
> Vivien: Ux PR https://github.com/mozilla-b2g/gaia/pull/8164 ;-)
I would like to merged but the PR is bitrotted. Feel free to merge when once it has been updated!
Attachment #705797 -
Flags: feedback?(21)
|
||
Updated•12 years ago
|
blocking-b2g: --- → leo?
|
|
||
Updated•12 years ago
|
blocking-b2g: leo? → ---
tracking-b2g18:
--- → ?
|
|
||
Comment 11•12 years ago
|
||
Tested on 19-03-2013 build of gaia/master and this bug appears to be fixed. Closing bug.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 12•12 years ago
|
||
Already fixed and a 'nice to have' go ahead with approval nomination.
status-b2g18:
--- → affected
|
|
Assignee | |
Updated•12 years ago
|
Attachment #705797 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 13•12 years ago
|
||
Attachment #728956 -
Flags: review?(sjochimek)
|
|
Assignee | |
Comment 14•12 years ago
|
||
Pointer to Github pull-request
|
|
||
Updated•12 years ago
|
Attachment #728956 -
Flags: review?(sjochimek) → review+
This patch hasn't landed on master. I don't see it any where in the code.
Looking from last commit : https://github.com/mozilla-b2g/gaia/commit/3f824d1dcb15c2c2f3e90483adc9f9d01f122477
Setting to reopened.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Updated•12 years ago
|
Whiteboard: visual design UX-P3 yedo, uxbranch, landed in uxbranch → visual design UX-P3 yedo,
|
|
||
Comment 16•12 years ago
|
||
pavel, can you check if this? And make sure it's landed in master?
Flags: needinfo?(pivanov)
|
|
Assignee | |
Comment 17•12 years ago
|
||
it's not landed yet. Sam ?
Flags: needinfo?(pivanov) → needinfo?(sjochimek)
|
|
Assignee | |
Comment 19•12 years ago
|
||
PR updated ;)
|
|
||
Comment 20•12 years ago
|
||
Landed in master : https://github.com/mozilla-b2g/gaia/commit/8df7686faf30ed372e3b4672f7972b67696a8c9c
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
To verify this bug, it's easier to just adb push large files into /data/local/tmp/ such as the zip build files.
Note settings will not refresh until either the window is refreshed (ie lockscreen and unlock, or exit out of settings and come back to it.
Master build :2013-04-22-03-05-57
"mozilla-central" revision="50d25e083421"
"integration/gaia-central" revision="6693344385fc"
"gecko.git" revision="12a533fa7b8fa09df333a0ca7041e9f467cb3f4a"
"gaia.git" revision="0874b5e84129391de9edb23560be8ad52b3d2bed"
Unagi
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•