[Settings] Device Storage Memory Usage Bar Needs Redesign

VERIFIED FIXED

Status

P3
normal
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: pla, Assigned: pivanov)

Tracking

unspecified
All
Other

Firefox Tracking Flags

(b2g18+ affected)

Details

(Whiteboard: visual design UX-P3 yedo, )

Attachments

(4 attachments, 2 obsolete attachments)

(Reporter)

Description

6 years ago
The green memory usage bar needs to be redesigned to line up with our look and feel.  It's currently a bit too 'pill' like in its shading.

Updated

6 years ago
Component: Gaia → Gaia::Settings
Doesn't follow our visual aesthetic, its worth looking at the progress bar.
Priority: -- → P3
Whiteboard: visual design → visual design, incorrect implementation
Keywords: polish
Whiteboard: visual design, incorrect implementation → visual design UX-P3 yedo
(Reporter)

Comment 2

6 years ago
Created attachment 705492 [details]
Mockup of Solution

Please implement the attached solution.
(Reporter)

Comment 3

6 years ago
Created attachment 705501 [details]
Slight update + spec on placement and overal dimensions

Use this updated version for implementation.
Attachment #705492 - Attachment is obsolete: true
(Reporter)

Comment 4

6 years ago
Hi Sam or Pavel, can one of you take this bug and implement it?  Let me know how you want the final graphical assets to be delivered.
Assignee: pla → pivanov
Created attachment 705797 [details]
patch for UX branch
Attachment #705797 - Flags: review?(sjochimek)
sorry for the mistake Sam :) now it's ok I think :)

Updated

6 years ago
Whiteboard: visual design UX-P3 yedo → visual design UX-P3 yedo, uxbranch, landed in uxbranch

Comment 8

6 years ago
Comment on attachment 705797 [details]
patch for UX branch

landed in uxbranch: https://github.com/gordonbrander/gaia/commit/3be5adfcb49c9cb8674215990818acca5f229937
Attachment #705797 - Flags: review?(sjochimek) → review+

Comment 9

6 years ago
Comment on attachment 705797 [details]
patch for UX branch

Vivien: Ux PR https://github.com/mozilla-b2g/gaia/pull/8164 ;-)
Attachment #705797 - Flags: feedback?(21)
(In reply to Sam Joch [:samjoch] from comment #9)
> Comment on attachment 705797 [details]
> patch for UX branch
> 
> Vivien: Ux PR https://github.com/mozilla-b2g/gaia/pull/8164 ;-)

I would like to merged but the PR is bitrotted. Feel free to merge when once it has been updated!

Updated

6 years ago
blocking-b2g: --- → leo?

Updated

6 years ago
blocking-b2g: leo? → ---
tracking-b2g18: --- → ?
Tested on 19-03-2013 build of gaia/master and this bug appears to be fixed.  Closing bug.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Already fixed and a 'nice to have' go ahead with approval nomination.
status-b2g18: --- → affected
tracking-b2g18: ? → +
Attachment #705797 - Attachment is obsolete: true
Created attachment 728956 [details]
patch for Gaia repo
Attachment #728956 - Flags: review?(sjochimek)
Created attachment 728957 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8796

Pointer to Github pull-request

Updated

6 years ago
Attachment #728956 - Flags: review?(sjochimek) → review+
This patch hasn't landed on master.  I don't see it any where in the code.

Looking from last commit : https://github.com/mozilla-b2g/gaia/commit/3f824d1dcb15c2c2f3e90483adc9f9d01f122477

Setting to reopened.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

6 years ago
Whiteboard: visual design UX-P3 yedo, uxbranch, landed in uxbranch → visual design UX-P3 yedo,
pavel, can you check if this?  And make sure it's landed in master?
Flags: needinfo?(pivanov)
it's not landed yet. Sam ?
Flags: needinfo?(pivanov) → needinfo?(sjochimek)

Comment 18

6 years ago
Waiting for update ... see github
Flags: needinfo?(sjochimek)
PR updated ;)

Comment 20

6 years ago
Landed in master : https://github.com/mozilla-b2g/gaia/commit/8df7686faf30ed372e3b4672f7972b67696a8c9c
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Created attachment 740464 [details]
screenshot

To verify this bug, it's easier to just adb push large files into /data/local/tmp/ such as the zip build files.
Note settings will not refresh until either the window is refreshed (ie lockscreen and unlock, or exit out of settings and come back to it.

Master build :2013-04-22-03-05-57
"mozilla-central" revision="50d25e083421"
"integration/gaia-central" revision="6693344385fc"
"gecko.git" revision="12a533fa7b8fa09df333a0ca7041e9f467cb3f4a"
"gaia.git" revision="0874b5e84129391de9edb23560be8ad52b3d2bed"
Unagi
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.