804193 - Implement the passcode "unlock" transition

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect, P3)

Description

[Peter La]

When unlocking the phone via passcode, the transition from the passcode entry screen to the homescreen/landing page/icon grid 'hiccups'.  It's really rough, and even flickers.

Comment 1

[Peter La]

Build tested on: otoro_2012-10-22_ics_us.

Comment 2

[steve]

Needs correct transition implented. See latest transition document for correct behaviour.

https://www.dropbox.com/sh/hcpn9opc593l7tx/7zqGtV_inH

Comment 3

[Peter La]

Rewriting using performance/ux-trust bug template.

--

What makes it feel slow/broken?

It is currently performing acceptably fast, but just using the wrong transition.  See link provided above by Steve.

The other problem is that the screen also flickers during/after the transition.

Did it prevent you from doing what you wanted? Why?

How does this make you feel?

[ ]  :)  I feel happy about it
[X]  :|  Meh
[ ]  :(  I'm upset
[ ] >:O  I'm angry

Device: Unagi, Nov. 22 Nightly.

Details: (technical factors, FPS, app startup time, ms elapsed, etc)

Bonus: can you attach a video of the problem?
Time permitting.

Comment 5

[Josh Carpenter [:jcarpenter]]

In 1/6 build there is no transition at all. As the user types the fourth correct digit, the screen freezes for a second, the fourth passcode slot remains blank, and the screen suddenly unlocks without any kind of animation. It creates a perception that the process is broken.

We need to implement some sort of transition here. 

The transitions UX specs are here: https://www.dropbox.com/sh/hcpn9opc593l7tx/7zqGtV_inH

See page 7.

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This is a recent regression.  Suspect related to bug 824454.

Comment 7

[Josh Carpenter [:jcarpenter]]

Hmm, weird, I just tried it again and this time after the brief freeze it did show a brief glimpse of the crossfade+zoom transition. It looks like there's a stutter in the rendering?

Comment 8

[Victoria Gerchinhoren [:vicky]]

Is not only that "hicup". The current transition is conceptually right (besides the hicups) when entering in the screen, but is not implemented the transition after entering the code and actually unlocking the screen.

PLease see page 7 of the transitions specs here: https://www.dropbox.com/sh/hcpn9opc593l7tx/7zqGtV_inH

Thanks!

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

With bug 824454, this platform regression is still visible.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #9)
> With bug 824454, this platform regression is still visible.

I cannot reproduce this reliably. It's possible the transition is unnoticed because the background is too dark; but we definitely skip the transition sometimes.

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

WIP for visual design, still investigating weird flash issue.

https://github.com/yurenju/gaia/commit/7f0911c15bcfe666974b84946bdde482d1a14eeb

Comment 12

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: pull request

Comment 13

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 700471 [details]
pull request

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 14

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/b1660301894fc96a258780f2031c8c27d75aaf5c