804329 - [socorro-crashstats] "[num] Results..." text needs more bottom padding

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

STR:

1. Load any search which returns results (from Advanced Search)
2. Look at the "127 Results … 1 2 Next →" text

Expected:

Has vertical padding above and below it and the bottom border

Actual:

See screenshot

Comment 1

[Robert Helmer [:rhelmer]]

Schalk, can you take a look at the CSS problem here? I am sure we introduced it in the new pagination impl.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/ed3d8f16c88737e4f55dcf63abff36a59021da77
give pagination some breathing room fixes bug 804329

https://github.com/mozilla/socorro-crashstats/commit/e9cf3c569eeebc5382043ddc085200bfcf25bd58
Merge pull request #225 from ossreleasefeed/bug804329-paging-need-more-padding-search

give pagination some breathing room fixes bug 804329

Comment 3

[Schalk Neethling [:espressive]]

Sent and merged: https://github.com/mozilla/socorro-crashstats/pull/225

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on:

http://crash-stats-new-dev.allizom.org/query/?product=Firefox&version=ALL%3AALL&platform=windows&range_value=1&range_unit=weeks&date=10%2F25%2F2012+18%3A21%3A08&query_search=signature&query_type=contains&query=malloc&reason=&build_id=&process_type=any&hang_type=any#advanced

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 6

[Schalk Neethling [:espressive]]

(In reply to Stephen Donner [:stephend] from comment #5)
> Created attachment 675214 [details]
> Post-fix screenshot

dude, this does not look good. Everything is now white ;();

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot