80433 - We create the items in the Mac help menu several times on startup

Status: RESOLVED INVALID

(Core Graveyard :: Widget: Mac, defect)

Description

[Andrew Thompson]

I've recently had occassion to add some debugging output to nsMenuItem.cpp and 
nsMenu.cpp ::create()

It seems we create the help menu and the 3 items on it (About Mozilla, About 
Plugins, Release Notes) 4 or 5 times over during startup *and* every time we 
switch into Mozilla.

Is this a bug? Can't be helping startup speed, though I doubt its significant...

Comment 1

[saari (gone)]

Because of the way we're hacking around with the menu manager and the dynamic
MDEF, we need to keep creating the Help menu. I know it sucks, but there is no
other way around it that I've found. 

Comment 2

[Frankie]

Is this bug relevant any more? Are there MDEFs in OS X?

Comment 3

[Andrew Thompson]

Yes, I think so.

Recall the back end has been converted to the Unix one, but the front end is
still the same Carbon code it always was. From a casual look at nsMenu.cpp, not
much seems to have changed.

Comment 4

[Mark Mentovai]

This is now invalid.  Help menus are no longer treated specially, they're now just regular menus that happen to be named "Help".  We build one for each window, including the hidden window (for a total of two on a normal startup), and do not waste time rebuilding them on application or window switch.