Closed Bug 804437 Opened 8 years ago Closed 8 years ago

user.js section in about:support is hidden but still copied to the clipboard when no user.js file exists

Categories

(Toolkit :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: Unfocused, Assigned: MattN)

References

Details

Attachments

(1 file)

Bug 557738 added a user.js section, which is hidden by default and shown only when a user.js file exists. However, whilst the section is hidden, it still gets copied to the clipboard when hitting the "Copy text to clipboard" button.

Instead of being left hidden, the section should be removed from the DOM if user.js doesn't exist.
It would probably be easier to set the class "no-copy" (from bug 787289) on the parent when display = none. Alternatively we could make the copy function filter based on visibility.
Good catch on this bug. I'm pretty sure I was testing this case initially but I guess I missed it on the final approach.
Assignee: nobody → mnoorenberghe+bmo
Status: NEW → ASSIGNED
Attachment #677177 - Flags: review?(bmcbride)
Comment on attachment 677177 [details] [diff] [review]
v.1 no-copy approach

Review of attachment 677177 [details] [diff] [review]:
-----------------------------------------------------------------

I'm just going to blindly assume you tested this :)
Attachment #677177 - Flags: review?(bmcbride) → review+
Yep, I tested.

https://hg.mozilla.org/integration/fx-team/rev/ec06d25faff3
OS: Windows 7 → All
Hardware: x86_64 → All
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/ec06d25faff3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.