804440 - [socorro-crashstats] daily doesn't pass the version parameter correctly

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. Load http://crash-stats-new-dev.allizom.org/daily?p=Firefox
2. In the Versions pulldown, select 19.0a1

Actual:

http://crash-stats-new-dev.allizom.org/daily?p=Firefox/versions/19.0a1 gives you:

p

    Select a valid choice. Firefox/versions/19.0a1 is not one of the available choices.

Comment 1

[Robert Helmer [:rhelmer]]

Oh, hm.. not sure what we should do in this case. The old site jumps back to the beginning, and this is using a different structure from the reports (it's more like search).

Comment 2

[Laura Thomson :laura]

I never liked that behavior in the old site, fwiw.

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to Laura Thomson :laura from comment #2)
> I never liked that behavior in the old site, fwiw.

Yeah I don't like it either and we have fixed it for the most part, but I notice /query is falling back to the old behavior. I think we might want to do that here, too.

Comment 4

[Robert Helmer [:rhelmer]]

r? https://github.com/mozilla/socorro-crashstats/pull/241

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/dd27dd6d55ffee6aebe957d2af6b68427f1905d4
fixes bug 804440 - use old version select behavior for /daily page, has it's own multi-select field

https://github.com/mozilla/socorro-crashstats/commit/8a100b4527a8c700dfabb87bf6106757bf6f5fe9
Merge pull request #241 from rhelmer/bug804440-daily-version-pulldown-broken

fixes bug 804440 - use old version select behavior for /daily page, has ...

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks!