Intermittent test_addons_store.js | test failed (with xpcshell return code: 0), see following log: followed by head.js | Error: AddonRepository search failed

RESOLVED WORKSFORME

Status

()

defect
RESOLVED WORKSFORME
7 years ago
8 months ago

People

(Reporter: mfinkle, Unassigned)

Tracking

({intermittent-failure})

Firefox Tracking Flags

(Not tracked)

Details

Rev3 WINNT 5.1 mozilla-beta debug test xpcshell on 2012-10-22 15:56:49 PDT for push 5357284cc014
https://tbpl.mozilla.org/php/getParsedLog.php?id=16359952&tree=Mozilla-Beta


TEST-INFO | c:\talos-slave\test\build\xpcshell\tests\services\sync\tests\unit\test_addons_store.js | running test ...
TEST-UNEXPECTED-FAIL | c:\talos-slave\test\build\xpcshell\tests\services\sync\tests\unit\test_addons_store.js | test failed (with xpcshell return code: 0), see following log:
>>>>>>>
### XPCOM_MEM_LEAK_LOG defined -- logging leaks to c:\docume~1\cltbld\locals~1\temp\tmpg1cna4\runxpcshelltests_leaks.log
Setting the identity for passphrase
JS Component Loader: WARNING c:/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/head_helpers.js -> file:///c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/head_addons.js:605
                     octal literals and octal escape sequences are deprecated
JS Component Loader: WARNING c:/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/head_helpers.js -> file:///c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/head_addons.js:605
                     octal literals and octal escape sequences are deprecated
JS Component Loader: WARNING c:/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/head_helpers.js -> file:///c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/head_addons.js:605
                     octal literals and octal escape sequences are deprecated
JS Component Loader: WARNING c:/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/head_helpers.js -> file:///c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/head_addons.js:623
                     octal literals and octal escape sequences are deprecated
JS Component Loader: WARNING c:/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/head_helpers.js -> file:///c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/head_addons.js:623
                     octal literals and octal escape sequences are deprecated
JS Component Loader: WARNING c:/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/head_helpers.js -> file:///c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/head_addons.js:623
                     octal literals and octal escape sequences are deprecated
JS Component Loader: WARNING c:/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/head_helpers.js -> file:///c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/head_addons.js:655
                     octal literals and octal escape sequences are deprecated
JS Component Loader: WARNING c:/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/head_helpers.js -> file:///c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/head_addons.js:655
                     octal literals and octal escape sequences are deprecated
JS Component Loader: WARNING c:/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/head_helpers.js -> file:///c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/head_addons.js:655
                     octal literals and octal escape sequences are deprecated
JS Component Loader: WARNING c:/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/head_helpers.js -> file:///c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/head_addons.js:708
                     octal literals and octal escape sequences are deprecated
JS Component Loader: WARNING c:/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/head_helpers.js -> file:///c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/head_addons.js:708
                     octal literals and octal escape sequences are deprecated
JS Component Loader: WARNING c:/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/head_helpers.js -> file:///c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/head_addons.js:708
                     octal literals and octal escape sequences are deprecated
JS Component Loader: WARNING c:/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/head_helpers.js -> file:///c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/head_addons.js:1004
                     function check_test_completed does not always return a value
JS Component Loader: WARNING c:/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/head_helpers.js -> file:///c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps*** LOG addons.manager: Application has been upgraded
*** LOG addons.xpi: startup
*** LOG addons.xpi: checkForChanges
*** LOG addons.xpi: No changes found


*** LOG addons.repository: Requesting http://localhost:8888/search/guid:bootstrap1%40tests.mozilla.org
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'JavaScript component does not have a method named: "readIntValue"' when calling method: [nsIWindowsRegKey::readIntValue]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "JS frame :: resource:///modules/AddonRepository.jsm :: AddonRepo_beginSearch :: line 1365"  data: no]
************************************************************

TEST-UNEXPECTED-FAIL | c:\talos-slave\test\build\xpcshell\head.js | Error: AddonRepository search failed - See following stack:
JS frame :: c:\talos-slave\test\build\xpcshell\head.js :: do_throw :: line 451
JS frame :: c:\talos-slave\test\build\xpcshell\head.js :: _run_next_test :: line 891
JS frame :: c:\talos-slave\test\build\xpcshell\head.js :: <TOP_LEVEL> :: line 418

TEST-INFO | (xpcshell/head.js) | exiting test

TEST-INFO | (xpcshell/head.js) | test 2 finished

TEST-PASS | c:/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/head_helpers.js -> file:///c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/head_addons.js | [null : 1266] false == false
Whiteboard: [orange]
Comment hidden (Legacy TBPL/Treeherder Robot)
This is XP, not Mac.

Given that this is on Beta, it looks like there is existing flakiness here, quite apart from Bug 804480, Bug 804470, Bug 795800
OS: Mac OS X → Windows XP
Blocks: 804673
I think there might have been a bit of flakiness overnight Monday night, too, before the merge-from-hell landed on inbound, which smelled to me a whole lot like someone was touching the network. You aren't touching the network, are you?
Overnight Sunday night. Is it really only Tuesday?
(In reply to Phil Ringnalda (:philor) from comment #4)
> Overnight Sunday night. Is it really only Tuesday?

Tell me about it! :D

(In reply to Phil Ringnalda (:philor) from comment #3)
> I think there might have been a bit of flakiness overnight Monday night,
> too, before the merge-from-hell landed on inbound, which smelled to me a
> whole lot like someone was touching the network. You aren't touching the
> network, are you?

It wouldn't surprise me if the add-ons layer tried to. I'll investigate. With any luck we'll get traction on Bug 804648, and we can find out for sure.

Tips on that welcome, btw…
Comment hidden (Legacy TBPL/Treeherder Robot)
Investigating these lines:

*** LOG addons.repository: Requesting http://localhost:8888/search/guid:missing%40tests.mozilla.org
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'JavaScript component does not have a method named: "readIntValue"' when calling method: [nsIWindowsRegKey::readIntValue]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "JS frame :: resource:///modules/AddonRepository.jsm :: AddonRepo_beginSearch :: line 1365"  data: no]
************************************************************

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'JavaScript component does not have a method named: "readIntValue"' when calling method: [nsIWindowsRegKey::readIntValue]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "JS frame :: resource://gre/modules/NetUtil.jsm :: NetUtil_newChannel :: line 233"  data: no]
************************************************************

etc.

Those lines are:

    LOG("Requesting " + aURI);

    this._request = Cc["@mozilla.org/xmlextras/xmlhttprequest;1"].
                    createInstance(Ci.nsIXMLHttpRequest);
    this._request.mozBackgroundRequest = true;
    this._request.open("GET", aURI, true);                            <<<<<<<<<<
    this._request.overrideMimeType("text/xml");

and in NetUtil:

        return this.ioService.newChannelFromURI(uri);



These are the only uses of readIntValue in mozilla-beta:

browser/components/migration/src/IEProfileMigrator.js
156:          return registry.readIntValue(aKey);

browser/components/preferences/advanced.js
539:      installed = wrk.readIntValue("Installed");

browser/components/preferences/in-content/advanced.js
530:      installed = wrk.readIntValue("Installed");

toolkit/mozapps/update/nsUpdateService.js
1713:      attempted = wrk.readIntValue("Attempted");
1714:      installed = wrk.readIntValue("Installed");



These are all about reading whether the MaintenanceService is installed.

Anyone know why attempting to open a localhost HTTP channel would result in the Windows registry being (unsuccessfully) hit?
Tagging bz for Comment 7.
Flags: needinfo?(bzbarsky)
CCing Unfocused, because he should have a much better idea of what AddonRepository is doing than I do!
Opening the channel will try to figure out what's going on with proxies, and toolkit/system/windowsproxy/nsWindowsSystemProxySettings.cpp will call ReadIntValue(NS_LITERAL_STRING("ProxyEnable")) in the process, presumably.

So that part looks correct enough to me.  Does that help?  ;)

(On a side note, there are other c++ callers of ReadIntValue: two in the crashreporter, two in the MIME service.  But I expect the proxy settings one is the one being hit here.)
Flags: needinfo?(bzbarsky)
(In reply to Boris Zbarsky (:bz) from comment #10)
> Opening the channel will try to figure out what's going on with proxies, and
> toolkit/system/windowsproxy/nsWindowsSystemProxySettings.cpp will call
> ReadIntValue(NS_LITERAL_STRING("ProxyEnable")) in the process, presumably.
> 
> So that part looks correct enough to me.  Does that help?  ;)

It might!

You might know the answer to my next two questions…

* Why is the subject of that method call a JS object which doesn't implement the method (which, if that really is the line, should be the result of `do_CreateInstance("@mozilla.org/windows-registry-key;1", &rv);`…)?

This smells like a bug hiding somewhere.

* How can we stop this from ever failing in our xpcshell tests? Presumably we can't simply disable proxy usage in AddonRepository.
(In reply to Boris Zbarsky (:bz) from comment #10)
> two in the MIME service

Mmm, I think there were some gconf handler failures in that Sunday night bunch, too.
Gonna flag this as [closeme]. Please clear that if it recurs!
Whiteboard: [orange] → [orange][closeme 2012-10-31]
(In reply to Richard Newman [:rnewman] from comment #11)
> Presumably
> we can't simply disable proxy usage in AddonRepository.

Indeed, we can't.
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
*sigh*
OS: Windows XP → All
Hardware: x86 → All
Whiteboard: [orange][closeme 2012-10-31] → [orange]
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Whiteboard: [orange]
Resolving WFM keyword:intermittent-failure bugs last modified >3 months ago, whose whiteboard contains none of:
{random,disabled,marked,fuzzy,todo,fails,failing,annotated,time-bomb,leave open}

There will inevitably be some false positives; for that (and the bugspam) I apologise. Filter on orangewfm.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WORKSFORME
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.