fb-privacy.less throws errors when compiled

RESOLVED FIXED

Status

www.mozilla.org
Bedrock
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: rik, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
Here is the error message:
[31mTypeError: Cannot call method 'charAt' of undefined
   at getLocation (/usr/lib/node_modules/less/lib/less/parser.js:212:34)
   at new LessError (/usr/lib/node_modules/less/lib/less/parser.js:221:19)
   at Object.toCSS (/usr/lib/node_modules/less/lib/less/parser.js:385:31)
   at /usr/lib/node_modules/less/bin/lessc:107:28
   at /usr/lib/node_modules/less/lib/less/parser.js:434:40
   at /usr/lib/node_modules/less/lib/less/parser.js:94:48
   at /usr/lib/node_modules/less/lib/less/index.js:116:17
   at Object.parse (/usr/lib/node_modules/less/lib/less/parser.js:436:17)
   at /usr/lib/node_modules/less/lib/less/index.js:115:16
   at [object Object].<anonymous> (fs.js:107:5)[39m

It's not really helpful because I think we're hitting a lessc bug in getLocation.
(Reporter)

Comment 1

6 years ago
So this look like a bug in variables-resp.css introduced in https://github.com/mozilla/bedrock/commit/b730d1e00670c8daa294158aa2d0d9b72bf13366

Comment 3

6 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/1532f1c25c3ba04d46fd1d7cf83a198e78e136f2
Change any CSS classes in variables/mixins files to be mixins (so they don't output redundant CSS)

bug 804475

https://github.com/mozilla/bedrock/commit/4e6dcfdd65e28ea8d893e7a8bf65b7d23d251037
Merge variables-resp.less and mixins-resp.less into a new lib.less

fix bug 804475

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 4

6 years ago
This has been pushed to production.
You need to log in before you can comment on or make changes to this bug.