804684 - [socorro-crashstats] Refactor IDs with uppercase.

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Peter Bengtsson [:peterbe]]

All occurances of things like `id="camelCase"` should be refactored to something safer such as `id="camel-case"`. 

This involves not just changing the HTML templates but also all javascript (e.g. s/#camelCase/#camel-case) and all Socorro-Tests code that depends on that ID.

Comment 1

[[e-mail]]

Is it still available this?

Comment 2

[Peter Bengtsson [:peterbe]]

(In reply to [e-mail] from comment #1)
> Is it still available this?

Grep the code for all occurances of `id=` in the the *.html files and look for patterns.

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

Vanessa, this is free for you to work on. Do you want me to assign you to this bug?

Comment 4

[[e-mail]]

Yes! I want to work on this bug :)

Comment 5

[[e-mail]]

(In reply to Peter Bengtsson [:peterbe] from comment #2)
> (In reply to [e-mail] from comment #1)
> > Is it still available this?
> 
> Grep the code for all occurances of `id=` in the the *.html files and look
> for patterns.

I found ID with camelcase but in a .tmpl file .¿Lo change there too or just js css or html files?

Comment 6

[Peter Bengtsson [:peterbe]]

I didn't even know we have .tmpl files. 

I think I've explain this bug poorly. 
I made a grep search on all of our .html files and found the following things to focus on:
https://gist.github.com/peterbe/15961ae8387e7936e3b6

For example, there is a `id="signatureList"` and that should become `id="signature-list"` and if this is referenced in a .css file or a .js file as `#signatureList` or `$('#signatureList')` it needs to change to `#signature-list` accordingly.

Comment 7

[[e-mail]]

I understood the bug, but I was wrong when I searched all ID with camelcase in Socorro project. I found .tmpl files, but these files are not you work on it, are dependencies installed. I was wrong on this, sorry, did not see it well before asking. The IDs you found, I had already changed, I thought there were more ID with camelcase. Then, you assured me that no more. Thank you very much for answering.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/81bd73df979e054877d4195d3f670d07b8d109a5
fix bug 804684. Changed the IDs without camelcase

https://github.com/mozilla/socorro/commit/118e49e43bb616808492233cbdde579023025520
Merge pull request #2757 from AdrianGaudebert/804684-refactor-ids

fix bug 804684. Changed the IDs without camelcase

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Peter Bengtsson [:peterbe] from comment #0)
> This involves not just changing the HTML templates but also all javascript
> (e.g. s/#camelCase/#camel-case) and all Socorro-Tests code that depends on
> that ID.

Socorro-Tests was not updated. See for example: https://github.com/mozilla/Socorro-Tests/blob/051d22f84c8993119c5a92356026547ab765ecbf/pages/crash_stats_top_crashers_page.py#L32

I will open an issue in the Socorro-Tests repository to address this.

Comment 10

[Dave Hunt [:davehunt] [he/him] ⌚BST]

See: https://github.com/mozilla/Socorro-Tests/issues/314