804686 - [socorro-crashstats] product is not passed to /query

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Robert Helmer [:rhelmer]]

This is why the selenium test "test_that_advanced_search_for_product_can_be_filtered" is failing, and quite likely others as well.

The old site uses a cookie to remember the user's last selected product, which we have (so far) opted not to do in the new site.

I propose that all links to /query specify the product, e.g.:

/query?product={{ product }}

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

(In reply to Robert Helmer [:rhelmer] from comment #0)
> I propose that all links to /query specify the product, e.g.:
> 
> /query?product={{ product }}

If you do that, it will run a search when you call that page. We removed the do_query=1 thing in the URL, so searches are run when either product, version, query or date has a value. We can remove the product parameter from this check, see: https://github.com/mozilla/socorro-crashstats/blob/master/crashstats/crashstats/views.py#L1098

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

PR: https://github.com/mozilla/socorro-crashstats/pull/228

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/00173f661b530e316d7f49e0650bfcf1c9c12331
Fixes bug 804686 - Added product in links to /query.

https://github.com/mozilla/socorro-crashstats/commit/deef0845ec4feb6f102955536a18f9ef1f00a5f2
Merge pull request #228 from AdrianGaudebert/804686-product-in-links-to-query

Fixes bug 804686 - Added product in links to /query.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

This bug doesn't completely fix test_that_advanced_search_for_product_can_be_filtered; see http://qa-selenium-stage.mv.mozilla.com:8080/job/socorro.dev.redesign/287/HTML_Report/? (I'll just reopen bug 803748.)