[socorro-crashstats] version passed to topchangers isn't correct

VERIFIED FIXED

Status

Socorro
Webapp
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: stephend, Assigned: rhelmer)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Comment 1

6 years ago
This harkens back to the early days of this code - this page still tries to work for single or multi-version selections.

This was done really inconsistently on the old app, so for the new one we decided to start with single-version-only and implement multi-version later, but this report didn't get the memo.
Assignee: nobody → rhelmer
Status: NEW → ASSIGNED
(Assignee)

Comment 2

6 years ago
Hmmm so actually https://crash-stats-dev.allizom.org/products/Firefox/topchangers it has a special behavior if "Current Versions" is selected. On second thought, let's preserve this for the moment, in case anyone depends on it (since it's the default)

Comment 4

6 years ago
Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/2d08c843bec42fc229e35fc1ed8d9e3d76a0b10d
fixes bug 804698 - support multi-version for topchangers report, both in URL and outgoing links to /report/list

https://github.com/mozilla/socorro-crashstats/commit/79a3ed8428a2438af476701285f2134b586284e9
Merge pull request #244 from rhelmer/bug804698-topchangers-multi-version

fixes bug 804698 - support multi-version for topchangers report, both in...

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

6 years ago
Created attachment 676425 [details]
Post-fix screenshot
You need to log in before you can comment on or make changes to this bug.