804702 - [clock] Show the alarm time which are set by user on the ringing page

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P2)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

## Environment :
Otoro phone, build 2012-10-23
Taken from default.xml in b2g-distro: 
* "platform_build" revision= db539a3bd139c93c09b0cd1c3f9396b74d68717c
* "gaia" revision= 0b8ec9b8c16429dc35453dbb7b9342fab3dd18fb 
* "releases-mozilla-aurora" revision= f58edfde05cb708f8a2c440d338f2e429aaf372b
* "gonk-misc" revision= db0c751715f4696515735eb1e0dc5df7a40eb81d

  
## Repro :
1. launch clock and set the alarm for 1 minute ahead
2. leave the device for 2 minutes
3. unlock the screen

## Expected :
1. the alarm sounding overlay shows the alarm time

## Actual :
1. the alarm sounding overlay shows the current time

## Note :
1. Because the alarm overlay shows the current time, the impression is that the alarm went off late.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

this is a UX bug.

Comment 2

[Gene Lian (I already quit Mozilla)]

According to Ian's saying, the current design is the alarm time shown on the alarm overlay (attention screen) is dynamically updated by the current clock time.

I agree with Naoki that this sounds a UX bug to me because *alarm time* showing on the attention screen should be the time you set for alarms (not clock time, though).

Comment 3

[Mike Connor [:mconnor]]

Per triage: while this is not optimal, it is not functionally broken.  It's probably an easy fix (don't dynamically update it), but we wouldn't hold the release on it.

Comment 5

[Gene Lian (I already quit Mozilla)]

Hi guys,

I'm hoping to ask bb+ again because our users would misunderstand the alarm didn't fire on time due to the wrongly displaying time on the ringing page and would have a bad impression that the alarm is broken. Please see Bug 811194 for this kind of user experience.

Sorry for asking again but I personally think this issue should be more critical than we thought, although it sounds like just a simple UI issue.

Comment 6

[[e-mail], [e-mail]]

I agree with Gene's suggestion.
But we should be careful about the display of *alarm time*.
It will not sync with the time of status bar.
We need UX to make a decision for the behavior.
So, I assign the issue to Josh.

Hi Josh,
Please re-assign to me after we have a confirmation.

Comment 7

[Josh Carpenter [:jcarpenter]]

Good catch, Gene. Let's make this change. The Alarm Screen will read the Alarm time, and the Status Bar will read the actual time. That way our sleepy user can glance at the screen and discern exactly how late they are.

Thanks guys. Let me know if you need anything from UX.

Comment 8

[Gene Lian (I already quit Mozilla)]

Hi Ian,

Now we're sure to show the alarm time on the ringing page, but one thing to note: better to show the alarm time *saved in the DB*, instead of reading the system time when firing, because the alarms that haven't go off during powering off will fire as soon as the device powers up.

Comment 9

[[e-mail], [e-mail]]

Since the pr https://github.com/mozilla-b2g/gaia/pull/6458 is merged, the issue is fixed by the patch.
We can close the issue now.

Comment 10

[John Shih]

verified on 2012-12-20-unagi
build info:
2012-12-18 unagi release build
gecko revision: "1527cf5192e32a1864dd47e38bfa8de7adf735ab"
gaia revision: "2b77f0a3fcc862c6925138d08fe44576da56bc7