Remove support for obsolete platforms

RESOLVED FIXED in 4.9.4

Status

defect
P1
normal
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: wtc, Assigned: wtc)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Description

7 years ago
I'd like to remove support for the following obsolete platforms:

ncr
nec
sony
nextstep (openstep)
reliantunix (sinix, sni)
sunos4

This is a very conservative list.

The first patch removes the _xxx.cfg, _xxx.h, and xxx.c files for
these platforms.
Attachment #674415 - Flags: superreview?(bsmith)
Attachment #674415 - Flags: review?(ted)
Comment on attachment 674415 [details] [diff] [review]
Remove the _xxx.cfg, _xxx.h, and xxx.c files for ncr, nec, sony, nextstep, reliantunix, and sunos4

Review of attachment 674415 [details] [diff] [review]:
-----------------------------------------------------------------

Wan-Teh, do you see this as a blocker for bug 757593?
Attachment #674415 - Flags: superreview?(bsmith) → superreview+
Assignee

Comment 2

7 years ago
Comment on attachment 674415 [details] [diff] [review]
Remove the _xxx.cfg, _xxx.h, and xxx.c files for ncr, nec, sony, nextstep, reliantunix, and sunos4

Brian: this bug doesn't need to block bug 757593 now after this
patch is checked in.

Patch checked in on the NSPR trunk (NSPR 4.9.4).

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.334; previous revision: 1.333
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.337; previous revision: 1.336
done
Checking in config/pathsub.h;
/cvsroot/mozilla/nsprpub/config/pathsub.h,v  <--  pathsub.h
new revision: 3.7; previous revision: 3.6
done
Removing pr/include/md/_ncr.cfg;
/cvsroot/mozilla/nsprpub/pr/include/md/_ncr.cfg,v  <--  _ncr.cfg
new revision: delete; previous revision: 3.8
done
Removing pr/include/md/_ncr.h;
/cvsroot/mozilla/nsprpub/pr/include/md/_ncr.h,v  <--  _ncr.h
new revision: delete; previous revision: 3.9
done
Removing pr/include/md/_nec.cfg;
/cvsroot/mozilla/nsprpub/pr/include/md/_nec.cfg,v  <--  _nec.cfg
new revision: delete; previous revision: 3.6
done
Removing pr/include/md/_nec.h;
/cvsroot/mozilla/nsprpub/pr/include/md/_nec.h,v  <--  _nec.h
new revision: delete; previous revision: 3.8
done
Removing pr/include/md/_nextstep.cfg;
/cvsroot/mozilla/nsprpub/pr/include/md/_nextstep.cfg,v  <--  _nextstep.cfg
new revision: delete; previous revision: 3.6
done
Removing pr/include/md/_nextstep.h;
/cvsroot/mozilla/nsprpub/pr/include/md/_nextstep.h,v  <--  _nextstep.h
new revision: delete; previous revision: 3.8
done
Removing pr/include/md/_reliantunix.cfg;
/cvsroot/mozilla/nsprpub/pr/include/md/_reliantunix.cfg,v  <--  _reliantunix.cfg
new revision: delete; previous revision: 3.8
done
Removing pr/include/md/_reliantunix.h;
/cvsroot/mozilla/nsprpub/pr/include/md/_reliantunix.h,v  <--  _reliantunix.h
new revision: delete; previous revision: 3.9
done
Removing pr/include/md/_sony.cfg;
/cvsroot/mozilla/nsprpub/pr/include/md/_sony.cfg,v  <--  _sony.cfg
new revision: delete; previous revision: 3.6
done
Removing pr/include/md/_sony.h;
/cvsroot/mozilla/nsprpub/pr/include/md/_sony.h,v  <--  _sony.h
new revision: delete; previous revision: 3.7
done
Removing pr/include/md/_sunos4.cfg;
/cvsroot/mozilla/nsprpub/pr/include/md/_sunos4.cfg,v  <--  _sunos4.cfg
new revision: delete; previous revision: 3.6
done
Removing pr/include/md/_sunos4.h;
/cvsroot/mozilla/nsprpub/pr/include/md/_sunos4.h,v  <--  _sunos4.h
new revision: delete; previous revision: 3.7
done
Checking in pr/include/md/prosdep.h;
/cvsroot/mozilla/nsprpub/pr/include/md/prosdep.h,v  <--  prosdep.h
new revision: 3.24; previous revision: 3.23
done
Removing pr/include/md/sunos4.h;
/cvsroot/mozilla/nsprpub/pr/include/md/sunos4.h,v  <--  sunos4.h
new revision: delete; previous revision: 3.7
done
Checking in pr/src/io/prscanf.c;
/cvsroot/mozilla/nsprpub/pr/src/io/prscanf.c,v  <--  prscanf.c
new revision: 3.13; previous revision: 3.12
done
Checking in pr/src/md/prosdep.c;
/cvsroot/mozilla/nsprpub/pr/src/md/prosdep.c,v  <--  prosdep.c
new revision: 3.16; previous revision: 3.15
done
Removing pr/src/md/unix/ncr.c;
/cvsroot/mozilla/nsprpub/pr/src/md/unix/ncr.c,v  <--  ncr.c
new revision: delete; previous revision: 3.7
done
Removing pr/src/md/unix/nec.c;
/cvsroot/mozilla/nsprpub/pr/src/md/unix/nec.c,v  <--  nec.c
new revision: delete; previous revision: 3.6
done
Removing pr/src/md/unix/nextstep.c;
/cvsroot/mozilla/nsprpub/pr/src/md/unix/nextstep.c,v  <--  nextstep.c
new revision: delete; previous revision: 3.6
done
Removing pr/src/md/unix/reliantunix.c;
/cvsroot/mozilla/nsprpub/pr/src/md/unix/reliantunix.c,v  <--  reliantunix.c
new revision: delete; previous revision: 3.7
done
Removing pr/src/md/unix/sony.c;
/cvsroot/mozilla/nsprpub/pr/src/md/unix/sony.c,v  <--  sony.c
new revision: delete; previous revision: 3.6
done
Removing pr/src/md/unix/sunos4.c;
/cvsroot/mozilla/nsprpub/pr/src/md/unix/sunos4.c,v  <--  sunos4.c
new revision: delete; previous revision: 3.6
done
Checking in pr/src/misc/prerrortable.c;
/cvsroot/mozilla/nsprpub/pr/src/misc/prerrortable.c,v  <--  prerrortable.c
new revision: 3.10; previous revision: 3.9
done
Attachment #674415 - Flags: review?(ted) → review+
Assignee

Comment 3

7 years ago
This patch finishes the job. It also removes the os_ReliantUNIX.s file,
which I missed in the first patch.

Ted: Please do a post-commit review. I will make any change you suggest
in a follow-up patch. Thanks.

Patch checked in on the NSPR trunk (NSPR 4.9.4).

Checking in config/Makefile.in;
/cvsroot/mozilla/nsprpub/config/Makefile.in,v  <--  Makefile.in
new revision: 1.27; previous revision: 1.26
done
Checking in config/nsinstall.c;
/cvsroot/mozilla/nsprpub/config/nsinstall.c,v  <--  nsinstall.c
new revision: 3.26; previous revision: 3.25
done
Checking in lib/ds/Makefile.in;
/cvsroot/mozilla/nsprpub/lib/ds/Makefile.in,v  <--  Makefile.in
new revision: 1.40; previous revision: 1.39
done
Checking in lib/libc/src/Makefile.in;
/cvsroot/mozilla/nsprpub/lib/libc/src/Makefile.in,v  <--  Makefile.in
new revision: 1.37; previous revision: 1.36
done
Checking in lib/prstreams/Makefile.in;
/cvsroot/mozilla/nsprpub/lib/prstreams/Makefile.in,v  <--  Makefile.in
new revision: 1.26; previous revision: 1.25
done
Checking in lib/prstreams/tests/testprstrm/Makefile.in;
/cvsroot/mozilla/nsprpub/lib/prstreams/tests/testprstrm/Makefile.in,v  <--  Makefile.in
new revision: 1.17; previous revision: 1.16
done
Checking in lib/tests/Makefile.in;
/cvsroot/mozilla/nsprpub/lib/tests/Makefile.in,v  <--  Makefile.in
new revision: 1.27; previous revision: 1.26
done
Checking in pr/include/gencfg.c;
/cvsroot/mozilla/nsprpub/pr/include/gencfg.c,v  <--  gencfg.c
new revision: 3.11; previous revision: 3.10
done
Checking in pr/include/md/_unixos.h;
/cvsroot/mozilla/nsprpub/pr/include/md/_unixos.h,v  <--  _unixos.h
new revision: 3.45; previous revision: 3.44
done
Checking in pr/include/private/primpl.h;
/cvsroot/mozilla/nsprpub/pr/include/private/primpl.h,v  <--  primpl.h
new revision: 3.96; previous revision: 3.95
done
Checking in pr/src/Makefile.in;
/cvsroot/mozilla/nsprpub/pr/src/Makefile.in,v  <--  Makefile.in
new revision: 1.64; previous revision: 1.63
done
Checking in pr/src/cplus/tests/Makefile.in;
/cvsroot/mozilla/nsprpub/pr/src/cplus/tests/Makefile.in,v  <--  Makefile.in
new revision: 1.16; previous revision: 1.15
done
Checking in pr/src/io/Makefile.in;
/cvsroot/mozilla/nsprpub/pr/src/io/Makefile.in,v  <--  Makefile.in
new revision: 1.16; previous revision: 1.15
done
Checking in pr/src/io/prfile.c;
/cvsroot/mozilla/nsprpub/pr/src/io/prfile.c,v  <--  prfile.c
new revision: 3.49; previous revision: 3.48
done
Checking in pr/src/io/prmapopt.c;
/cvsroot/mozilla/nsprpub/pr/src/io/prmapopt.c,v  <--  prmapopt.c
new revision: 3.23; previous revision: 3.22
done
Checking in pr/src/linking/Makefile.in;
/cvsroot/mozilla/nsprpub/pr/src/linking/Makefile.in,v  <--  Makefile.in
new revision: 1.21; previous revision: 1.20
done
Checking in pr/src/linking/prlink.c;
/cvsroot/mozilla/nsprpub/pr/src/linking/prlink.c,v  <--  prlink.c
new revision: 3.113; previous revision: 3.112
done
Checking in pr/src/malloc/Makefile.in;
/cvsroot/mozilla/nsprpub/pr/src/malloc/Makefile.in,v  <--  Makefile.in
new revision: 1.13; previous revision: 1.12
done
Checking in pr/src/md/prosdep.c;
/cvsroot/mozilla/nsprpub/pr/src/md/prosdep.c,v  <--  prosdep.c
new revision: 3.17; previous revision: 3.16
done
Checking in pr/src/md/beos/beos_errors.c;
/cvsroot/mozilla/nsprpub/pr/src/md/beos/beos_errors.c,v  <--  beos_errors.c
new revision: 3.10; previous revision: 3.9
done
Checking in pr/src/md/unix/Makefile.in;
/cvsroot/mozilla/nsprpub/pr/src/md/unix/Makefile.in,v  <--  Makefile.in
new revision: 1.29; previous revision: 1.28
done
Removing pr/src/md/unix/os_ReliantUNIX.s;
/cvsroot/mozilla/nsprpub/pr/src/md/unix/os_ReliantUNIX.s,v  <--  os_ReliantUNIX.s
new revision: delete; previous revision: 3.7
done
Checking in pr/src/md/unix/unix.c;
/cvsroot/mozilla/nsprpub/pr/src/md/unix/unix.c,v  <--  unix.c
new revision: 3.63; previous revision: 3.62
done
Checking in pr/src/md/unix/unix_errors.c;
/cvsroot/mozilla/nsprpub/pr/src/md/unix/unix_errors.c,v  <--  unix_errors.c
new revision: 3.31; previous revision: 3.30
done
Checking in pr/src/md/unix/uxproces.c;
/cvsroot/mozilla/nsprpub/pr/src/md/unix/uxproces.c,v  <--  uxproces.c
new revision: 3.28; previous revision: 3.27
done
Checking in pr/src/md/unix/uxrng.c;
/cvsroot/mozilla/nsprpub/pr/src/md/unix/uxrng.c,v  <--  uxrng.c
new revision: 1.27; previous revision: 1.26
done
Checking in pr/src/md/unix/uxwrap.c;
/cvsroot/mozilla/nsprpub/pr/src/md/unix/uxwrap.c,v  <--  uxwrap.c
new revision: 3.17; previous revision: 3.16
done
Checking in pr/src/misc/prtime.c;
/cvsroot/mozilla/nsprpub/pr/src/misc/prtime.c,v  <--  prtime.c
new revision: 3.47; previous revision: 3.46
done
Checking in pr/src/pthreads/Makefile.in;
/cvsroot/mozilla/nsprpub/pr/src/pthreads/Makefile.in,v  <--  Makefile.in
new revision: 1.16; previous revision: 1.15
done
Checking in pr/src/pthreads/ptio.c;
/cvsroot/mozilla/nsprpub/pr/src/pthreads/ptio.c,v  <--  ptio.c
new revision: 3.119; previous revision: 3.118
done
Checking in pr/src/threads/combined/Makefile.in;
/cvsroot/mozilla/nsprpub/pr/src/threads/combined/Makefile.in,v  <--  Makefile.in
new revision: 1.14; previous revision: 1.13
done
Checking in pr/tests/Makefile.in;
/cvsroot/mozilla/nsprpub/pr/tests/Makefile.in,v  <--  Makefile.in
new revision: 1.71; previous revision: 1.70
done
Checking in pr/tests/dll/Makefile.in;
/cvsroot/mozilla/nsprpub/pr/tests/dll/Makefile.in,v  <--  Makefile.in
new revision: 1.20; previous revision: 1.19
done
Checking in tools/Makefile.in;
/cvsroot/mozilla/nsprpub/tools/Makefile.in,v  <--  Makefile.in
new revision: 1.18; previous revision: 1.17
done
Attachment #681237 - Flags: review?(ted)
Assignee

Updated

7 years ago
Attachment #681237 - Attachment description: Remove code related to NCR, NEC, NEXTSTEP, SINIX, SNI, SONY, NEWS-OS, SunOS4, and SunOS 4.1.3_U1 → Remove code related to NCR, NEC, NEXTSTEP, SINIX, SNI, SONY, NEWS-OS, SUNOS4, and SunOS 4.1.3_U1
Assignee

Comment 4

7 years ago
I attached the wrong patch. Sorry. This is the right patch.
Attachment #681237 - Attachment is obsolete: true
Attachment #681237 - Flags: review?(ted)
Attachment #681330 - Flags: review?(ted)
Assignee

Comment 5

7 years ago
NSPR_4_9_4_BETA2 (which contains the second patch) pushed to mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c44db6486c0d
https://hg.mozilla.org/mozilla-central/rev/c44db6486c0d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment on attachment 681330 [details] [diff] [review]
[Correct patch] Remove code related to NCR, NEC, NEXTSTEP, SINIX, SNI, SONY, NEWS-OS, SUNOS4, and SunOS 4.1.3_U1

Review of attachment 681330 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, took me a little while to find time to look at this patch. This looks fine.
Attachment #681330 - Flags: review?(ted) → review+
You need to log in before you can comment on or make changes to this bug.