804829 - Cursor thumb scrolls when pointing to a position fixed textbox

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Wesley Johnston (:wesj)]

Noticed this on the netflix login box. The login box is in a position fixed popup window. Scrolling the page does not scroll the login box, but does scroll the thumb.

STR:
Go to netflix.com (desktop site)
Tap member sign in
Focus the textbox
Scroll the page

Comment 1

[:Margaret Leibovic]

I wonder if the same thing happens if there's active text selection on a position:fixed; text element.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Yup, same thing happens there. If we can reliably tell that the selection is on a fixed-position element then we should be able to tell java to not move the handles on panning, which should fix this problem. Alternatively we could re-send the PositionHandles message every time we pan while having a selection on a fixed-position element. I don't think that would work nearly as well though.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Working on a patch.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: WIP

This is harder than I thought. The attached patch takes care of not moving the handles when they're on a fixed-position element and you scroll. However if you zoom they go out of whack, and also if you go into overscroll they don't move even though the fixed-position content does.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

(In reply to Kartikaya Gupta (:kats) from comment #2)
> Alternatively we
> could re-send the PositionHandles message every time we pan while having a
> selection on a fixed-position element. I don't think that would work nearly
> as well though.

Now I think this other approach might be the right way to go. Feel free to grab this bug from me though, I'm gonna switch contexts to something else now.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Unassigning from myself since I'm not really working on this and bnicholson seems to have taken over the text selection code :)

Comment 7

[Brian Nicholson (:bnicholson)]

There's other issues with scrolling + showing the handle, such as scrolling a <textarea> that overflows (see http://people.mozilla.com/~bnicholson/test/form.html).

Maybe we could just hide the handle whenever its document is scrolled?

Comment 8

[Kartikaya Gupta (email:[e-mail])]

That's not a bad idea. We'd have to make sure though that if you're dragging a selection handle past the end of the page to scroll it and continue selecting that still works as intended.

Comment 9

[Mark Capella [:capella]]

Pruning some old bugs obviated by new Core/Layout AccessibleCaret implementation.