804890 - [Home] Screen dims out and not cancallable

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P3)

Description

[Al Tsai [:atsai]]

After unanswered incoming call, the luminous intensity isn't displayed as setting.

Reproduce Step:
1. Set the luminous intensity to a fixed value (I set it as the brightest)
2. Lock the phone
3. Call the phone and hang of the phone without answered it
4. Unlock the phone

Expected Result:
*. Back in home screen with the brightest luminous intensity

Actual Result:
*. The darkest luminous intensity

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Thanks Al!  I noticed that the luminosity kept changing and I couldn't figure out how to repro it consistantly.

Comment 2

[Chiajung Hung [:chiajung]]

Attachment: Pointer to Github: https://github.com/mozilla-b2g/gaia/pull/6102

https://github.com/mozilla-b2g/gaia/pull/6102

In original screen_manager implementation it use idleService to help determine user idle state. However, idleService report idle count not from observer registration but last user input (key, mouse or touch), which cause some false alarm and cause the problem.

In this patch, Tim provide a wrapper function for idleService that report user idle count from registration, and calls the user defined idleCallback. And if the idleCallback got called then user interact with device, then activeCallback get called.

Based on this wrapper, I change screen_manager implementation to use it.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I cannot review the code since I am one of the co-authors. We deliver this fix based on Chiajung's detailed breakdown on what's really going on with idleObserver API.

I consider this is the beginning to fix a lot of workaround and extra code handling screen idle/dimming quirks, so we should land this as soon as possible. Thanks.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 677318 [details] [review]
Pointer to Github: https://github.com/mozilla-b2g/gaia/pull/6102

I asked Jonas about it and it says this is the right approach. r+.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thanks, I will merge another pull request fixing some of the small issue in Chiajung's code.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Github: https://github.com/mozilla-b2g/gaia/pull/6182

Patch to merge, small nits fixes.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/pull/6182

Comment 9

[Rebecca Billings [:rbillings]]

Verified fix on the 11/12 otoro us build.