804897 - SourceCompressor should use updateMallocCounter with compartment

Status: RESOLVED DUPLICATE of bug 804857

(Core :: JavaScript Engine, defect)

Description

[Ginn Chen]

data.compressed is using cx->malloc_(nbytes), which updateMallocCounter to compartment.

On compression complete, it calls
saveTok->cx->runtime->updateMallocCounter(NULL, delta);

Because of the NULL ptr, it adds counts to outside compartment.
After several compressions, the count outside compartment overflows, onTooMuchMalloc() is called and triggers GC.

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 674582 [details] [diff] [review]
patch

Review of attachment 674582 [details] [diff] [review]:
-----------------------------------------------------------------

Seems ok to me, but I'm going to wimp out this one-line review and ask billm to do it, because he understands this stuff better than I do.

Comment 3

[:Benjamin Peterson]

I should note the patches to bug 804857 will "fix" this by allocating everything on the runtime.

Comment 4

[Ginn Chen]

Confirmed this problem will be gone with the patches of bug 804857.

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Isn't this still a problem?

Comment 7

[Ginn Chen]

(In reply to Bill McCloskey (:billm) from comment #6)
> Isn't this still a problem?

The problem of overflow and trigger GC is gone.

If you think the malloc should be count on compartment, this bug should be reopened.