804907 - [email] Create dialog to notify of send failure

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P1)

Description

[Dylan Oliver [:doliver]]

Because we have said V1 will not save any draft emails, we need to notify users when their attempt to send email fails, and offer them a choice to retry or discard the current message.

Comment 1

[Dylan Oliver [:doliver]]

Casey, this is from our discussion with Chris Lee last week. Can you update wireframes with a mockup of this dialog?

Comment 2

[Mike Connor [:mconnor]]

Blocking on this so we can remove saving drafts from v1.

Comment 3

[Steve Chung [:steveck]]

Attachment: Patch for adding new dialog to notify of send failure

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 677291 [details]
Patch for adding new dialog to notify of send failure

From the discussion (that we didn't describe on the bug, and the wireframes haven't been updated to reflect, sorry!), we don't want to discard the message if send fails.  Instead, we should return to the compose page.  That way the user can try and re-send the e-mail if they want or maybe add some more text or what not.  I believe this was the result of our discussion.  (The other possibility is to have a "Retry" or "Discard" page, but since we can effectively get the same thing from the compose page, the compose page seems the easier option.)

"Send email failed" is more properly "Sending email failed", but I think we want a string more like: "Failed to send message."  It might be best to ping jcarpenter to ask for guidance there (or I think there may be a strings expert?).

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

This will require a minor fix to mailapi.js to cause it to stop killing the MailComposition instance after the first call to finishCompositionSendMessage in all cases.  I'll change it so that in an error case, we leave the composition instance intact so that we can keep calling finishCompositionSendMessage until it works.  I'll try and do that tonight.

Comment 6

[Steve Chung [:steveck]]

(In reply to Andrew Sutherland (:asuth) from comment #5)
> This will require a minor fix to mailapi.js to cause it to stop killing the
> MailComposition instance after the first call to
> finishCompositionSendMessage in all cases.  I'll change it so that in an
> error case, we leave the composition instance intact so that we can keep
> calling finishCompositionSendMessage until it works.  I'll try and do that
> tonight.

I discard the message because finishCompositionSendMessage will make MailComposition instance unable to resend like you said. It would be great if the change won't cost an arm and a leg. I will change the confirm button behavior to stay in compose view and you can verify it when finishCompositionSendMessage changes lands.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Steve Chung from comment #6)
> I discard the message because finishCompositionSendMessage will make
> MailComposition instance unable to resend like you said. It would be great
> if the change won't cost an arm and a leg. I will change the confirm button
> behavior to stay in compose view and you can verify it when
> finishCompositionSendMessage changes lands.

Yes, this was a reasonable call given my prior feedback about the banner stuff (when we were going to implement automatic resending, etc.) and lack of a spec.

I have a review request up with a fix at:
https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/74

Once that is approved I'll change the string and land all of these together.  Thanks!

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

The gaia-email-libs-and-more fix got reviewed, so I have folded that and the minor string change I proposed (we still will want to re-word most of our strings anyways) into https://github.com/mozilla-b2g/gaia/pull/6162 and landed it with merge:
https://github.com/mozilla-b2g/gaia/commit/4d3ed8fc0f88fee60742d0a521a98c0e49d9c4ac

I have filed bug 808503 to track the need to actually get this documented in wire-frames.

Comment 9

[J Zimbrick]

Appears fixed in Unagi build 20121231070201.

A message now appears when attempting to send an e-mail without a connection displaying "Sending email failed".

Verifying as fixed.