View button in Message security of Compose window does nothing when the address has no certificate

RESOLVED FIXED in Thunderbird 19.0

Status

MailNews Core
Security: S/MIME
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

({polish})

Trunk
Thunderbird 19.0
polish
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.61 KB, patch
Magnus Melin
: review+
rkent
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
View button in Message security of Compose window does nothing when clicked on. The button is enabled but clicking it does nothing. It is probably because there is no certificate for the selected address.

I propose to disable the button in this case AND to change the label to "View..." as it opens a subdialog.
(Assignee)

Comment 1

5 years ago
Created attachment 674737 [details] [diff] [review]
patch
Attachment #674737 - Flags: ui-review?(bwinton)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED

Comment 2

5 years ago
There shouldn't be ellipsis for this just because it opens a new window. Ellipsis implies further action(s), but here it does all it should.
Summary: View button in Message security of Compose window does nothing → View button in Message security of Compose window does nothing when the address has no certificate
Comment on attachment 674737 [details] [diff] [review]
patch

(In reply to Magnus Melin from comment #2)
> There shouldn't be ellipsis for this just because it opens a new window.
> Ellipsis implies further action(s), but here it does all it should.

I agree.  It's like "About Thunderbird".

But, other than that, I like it.  ui-r=me with that changed back.  :)

Thanks,
Blake.
Attachment #674737 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Comment 4

5 years ago
Created attachment 676268 [details] [diff] [review]
patch v2
Attachment #674737 - Attachment is obsolete: true
Attachment #676268 - Flags: review?(mkmelin+mozilla)

Comment 5

5 years ago
Comment on attachment 676268 [details] [diff] [review]
patch v2

Review of attachment 676268 [details] [diff] [review]:
-----------------------------------------------------------------

Good fix, r=mkmelin
Attachment #676268 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 6

5 years ago
Comment on attachment 676268 [details] [diff] [review]
patch v2

Technically the change is in mailnews so it will probably need a stamp from a mailnews peers.
Attachment #676268 - Flags: review?(kent)

Comment 7

5 years ago
Comment on attachment 676268 [details] [diff] [review]
patch v2

I'll r+ this relying on mkmelin without testing myself.
Attachment #676268 - Flags: review?(kent) → review+
(Assignee)

Comment 8

5 years ago
Yeah, thanks.
Keywords: checkin-needed, polish
https://hg.mozilla.org/comm-central/rev/be89a8566060
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.