Last Comment Bug 804955 - View button in Message security of Compose window does nothing when the address has no certificate
: View button in Message security of Compose window does nothing when the addre...
Status: RESOLVED FIXED
: polish
Product: MailNews Core
Classification: Components
Component: Security: S/MIME (show other bugs)
: Trunk
: All All
: -- minor (vote)
: Thunderbird 19.0
Assigned To: :aceman
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-24 02:07 PDT by :aceman
Modified: 2012-11-03 16:49 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (5.02 KB, patch)
2012-10-24 10:41 PDT, :aceman
bwinton: ui‑review+
Details | Diff | Review
patch v2 (1.61 KB, patch)
2012-10-29 12:39 PDT, :aceman
mkmelin+mozilla: review+
rkent: review+
Details | Diff | Review

Description :aceman 2012-10-24 02:07:26 PDT
View button in Message security of Compose window does nothing when clicked on. The button is enabled but clicking it does nothing. It is probably because there is no certificate for the selected address.

I propose to disable the button in this case AND to change the label to "View..." as it opens a subdialog.
Comment 1 :aceman 2012-10-24 10:41:32 PDT
Created attachment 674737 [details] [diff] [review]
patch
Comment 2 Magnus Melin 2012-10-24 12:00:38 PDT
There shouldn't be ellipsis for this just because it opens a new window. Ellipsis implies further action(s), but here it does all it should.
Comment 3 Blake Winton (:bwinton) (:☕️) (PTO 'til London. Find me there for quick answers!) 2012-10-29 10:18:28 PDT
Comment on attachment 674737 [details] [diff] [review]
patch

(In reply to Magnus Melin from comment #2)
> There shouldn't be ellipsis for this just because it opens a new window.
> Ellipsis implies further action(s), but here it does all it should.

I agree.  It's like "About Thunderbird".

But, other than that, I like it.  ui-r=me with that changed back.  :)

Thanks,
Blake.
Comment 4 :aceman 2012-10-29 12:39:45 PDT
Created attachment 676268 [details] [diff] [review]
patch v2
Comment 5 Magnus Melin 2012-11-03 12:25:39 PDT
Comment on attachment 676268 [details] [diff] [review]
patch v2

Review of attachment 676268 [details] [diff] [review]:
-----------------------------------------------------------------

Good fix, r=mkmelin
Comment 6 :aceman 2012-11-03 14:56:59 PDT
Comment on attachment 676268 [details] [diff] [review]
patch v2

Technically the change is in mailnews so it will probably need a stamp from a mailnews peers.
Comment 7 Kent James (:rkent) 2012-11-03 15:30:28 PDT
Comment on attachment 676268 [details] [diff] [review]
patch v2

I'll r+ this relying on mkmelin without testing myself.
Comment 8 :aceman 2012-11-03 15:34:53 PDT
Yeah, thanks.
Comment 9 Ryan VanderMeulen [:RyanVM] 2012-11-03 16:49:49 PDT
https://hg.mozilla.org/comm-central/rev/be89a8566060

Note You need to log in before you can comment on or make changes to this bug.