WebTelephony API: DOM does not accurately handle an outgoing call

RESOLVED FIXED in Firefox 18

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: hsinyi, Assigned: hsinyi)

Tracking

unspecified
mozilla19
ARM
Gonk (Firefox OS)
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed)

Details

(Whiteboard: [LOE:S])

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
The DOM API does not accurately represent a call that wasn't placed through it. The DOM thinks whenever there's an unknown call, that should be incoming [1]. But that call could be placed by others (like STK call or by other process).

[1] http://mxr.mozilla.org/mozilla-central/source/dom/telephony/Telephony.cpp#405
(Assignee)

Updated

7 years ago
Blocks: 802745
How is STK placing the call if not trough the API?
(Assignee)

Comment 2

7 years ago
(In reply to Mounir Lamouri (:mounir) from comment #1)
> How is STK placing the call if not trough the API?

Hi Mounir, 

The STK call is made through STK app by selecting stk menu, not through telephony API. The SIM makes the call according to the menu command. You may refer to Yoshi's comment here [1] for the behaviour of STK call. 

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=804073#c9
(Assignee)

Comment 3

7 years ago
bb? because this blocks bb+ Bug 802745
blocking-basecamp: --- → ?
Hsin-Yi, who will do this work?
blocking-basecamp: ? → +
(Assignee)

Updated

7 years ago
Assignee: nobody → htsai
Whiteboard: [LOE:S]
(Assignee)

Comment 5

7 years ago
Posted patch PatchSplinter Review
handled 'outgoing' call placed by others
(Assignee)

Updated

7 years ago
Attachment #676438 - Flags: review?(bent.mozilla)
Comment on attachment 676438 [details] [diff] [review]
Patch

Review of attachment 676438 [details] [diff] [review]:
-----------------------------------------------------------------

I can't see how this will add the outgoing call to the mCalls array or send the callschanged event.
Attachment #676438 - Flags: review?(bent.mozilla) → review-
Comment on attachment 676438 [details] [diff] [review]
Patch

Review of attachment 676438 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, yes I can. Sorry, this looks good!

::: dom/telephony/Telephony.cpp
@@ +426,1 @@
>    return NS_OK;

Nit: Please add an extra line between the } and return.
Attachment #676438 - Flags: review- → review+
(Assignee)

Comment 8

7 years ago
(In reply to ben turner [:bent] from comment #7)
> Comment on attachment 676438 [details] [diff] [review]
> Patch
> 
> Review of attachment 676438 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Oh, yes I can. Sorry, this looks good!
>
Great, thanks!
 
> ::: dom/telephony/Telephony.cpp
> @@ +426,1 @@
> >    return NS_OK;
> 
> Nit: Please add an extra line between the } and return.
OK~
https://hg.mozilla.org/mozilla-central/rev/7781dba5ed5e
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.